archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix property list stacked UI

Browse Source 
Summary: The stacked version of property lists is supposed to display like a normal definition list.

Test Plan: Test the stacked layout in Herald.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11014
This commit is contained in:
Chad Little
2014-12-18 14:42:26 -08:00
parent d2df3064bc
commit 8ff9d52a59
3 changed files with 23 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
resources/celerity/map.php
View File

@@ -7,7 +7,7 @@
*/
return array(
'names' => array(
'core.pkg.css' => '2beb34f5',
'core.pkg.css' => '03a41753',
'core.pkg.js' => 'bc72b978',
'darkconsole.pkg.js' => 'df001cab',
'differential.pkg.css' => '8af45893',
@@ -137,7 +137,7 @@ return array(
'rsrc/css/phui/phui-object-box.css' => 'e9f7e938',
'rsrc/css/phui/phui-object-item-list-view.css' => '4e541c2c',
'rsrc/css/phui/phui-pinboard-view.css' => '3dd4a269',
'rsrc/css/phui/phui-property-list-view.css' => '86f9df88',
'rsrc/css/phui/phui-property-list-view.css' => '51480060',
'rsrc/css/phui/phui-remarkup-preview.css' => '19ad512b',
'rsrc/css/phui/phui-spacing.css' => '042804d6',
'rsrc/css/phui/phui-status.css' => '888cedb8',
@@ -787,7 +787,7 @@ return array(
'phui-object-box-css' => 'e9f7e938',
'phui-object-item-list-view-css' => '4e541c2c',
'phui-pinboard-view-css' => '3dd4a269',
'phui-property-list-view-css' => '86f9df88',
'phui-property-list-view-css' => '51480060',
'phui-remarkup-preview-css' => '19ad512b',
'phui-spacing-css' => '042804d6',
'phui-status-list-view-css' => '888cedb8',

4
src/view/phui/PHUIPropertyListView.php
View File

@@ -204,7 +204,7 @@ final class PHUIPropertyListView extends AphrontView {
$list = phutil_tag(
'dl',
array(
'class' => 'phui-property-list-properties '.$stacked,
'class' => 'phui-property-list-properties',
),
$items);
@@ -216,7 +216,7 @@ final class PHUIPropertyListView extends AphrontView {
$list = phutil_tag(
'div',
array(
'class' => 'phui-property-list-properties-wrap',
'class' => 'phui-property-list-properties-wrap '.$stacked,
),
array($shortcuts, $list));

29
webroot/rsrc/css/phui/phui-property-list-view.css
View File

@@ -55,13 +55,19 @@
margin-bottom: 4px;
}
.device .phui-property-list-key,
.phui-property-list-properties.phui-property-list-stacked
.phui-property-list-key {
padding-left: 12px;
text-align: left;
margin-left: 0;
.phui-property-list-properties-wrap.phui-property-list-stacked {
width: auto;
float: none;
}
.device .phui-property-list-key,
.phui-property-list-stacked .phui-property-list-properties
.phui-property-list-key {
padding-left: 12px;
text-align: left;
margin-left: 0;
width: auto;
float: none;
}
.phui-property-list-value {
@@ -77,12 +83,13 @@
}
.device .phui-property-list-value,
.phui-property-list-properties.phui-property-list-stacked
.phui-property-list-stacked .phui-property-list-properties
.phui-property-list-value {
padding: 0 16px;
margin-bottom: 8px;
width: auto;
word-break: break-word;
padding: 0 16px;
margin-bottom: 8px;
width: auto;
word-break: break-word;
float: none;
}
.phui-property-list-section-header {