Provide convenience method addTextCrumb() to PhabricatorCrumbsView

Summary: We currently have a lot of calls to `addCrumb(id(new PhabricatorCrumbView())->...)` which can be expressed much more simply with a convenience method. Nearly all crumbs are only textual.

Test Plan:
  - This was mostly automated, then I cleaned up a few unusual sites manually.
  - Bunch of grep / randomly clicking around.

Reviewers: btrahan, chad

Reviewed By: btrahan

CC: hach-que, aran

Differential Revision: https://secure.phabricator.com/D7787

src/applications/drydock/controller/DrydockBlueprintEditController.php

@@ -80,12 +80,8 @@ final class DrydockBlueprintEditController extends DrydockController {
 
     $title = pht('Edit Blueprint');
     $header = pht('Edit Blueprint %d', $blueprint->getID());
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Blueprint %d', $blueprint->getID())));
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Edit')));
+    $crumbs->addTextCrumb(pht('Blueprint %d', $blueprint->getID()));
+    $crumbs->addTextCrumb(pht('Edit'));
 
     if ($request->isAjax()) {
       $dialog = id(new AphrontDialogView())

src/applications/drydock/controller/DrydockBlueprintListController.php

@@ -18,10 +18,7 @@ final class DrydockBlueprintListController extends DrydockController {
     $blueprint_list = $this->buildBlueprintListView($blueprints);
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setName($title)
-        ->setHref($request->getRequestURI()));
+    $crumbs->addTextCrumb($title, $request->getRequestURI());
 
     $crumbs->addAction(
       id(new PHUIListItemView())

src/applications/drydock/controller/DrydockBlueprintViewController.php

@@ -42,9 +42,7 @@ final class DrydockBlueprintViewController extends DrydockController {
 
     $crumbs = $this->buildApplicationCrumbs();
     $crumbs->setActionList($actions);
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Blueprint %d', $blueprint->getID())));
+    $crumbs->addTextCrumb(pht('Blueprint %d', $blueprint->getID()));
 
     $object_box = id(new PHUIObjectBoxView())
       ->setHeader($header)

src/applications/drydock/controller/DrydockLeaseListController.php

@@ -31,10 +31,7 @@ final class DrydockLeaseListController extends DrydockController {
       ));
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setName($title)
-        ->setHref($request->getRequestURI()));
+    $crumbs->addTextCrumb($title, $request->getRequestURI());
     $nav->setCrumbs($crumbs);
 
     return $this->buildApplicationPage(

src/applications/drydock/controller/DrydockLeaseViewController.php

@@ -40,10 +40,7 @@ final class DrydockLeaseViewController extends DrydockController {
 
     $crumbs = $this->buildApplicationCrumbs();
     $crumbs->setActionList($actions);
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setName($title)
-        ->setHref($lease_uri));
+    $crumbs->addTextCrumb($title, $lease_uri);
 
     $object_box = id(new PHUIObjectBoxView())
       ->setHeader($header)

src/applications/drydock/controller/DrydockLogController.php

@@ -43,10 +43,7 @@ final class DrydockLogController extends DrydockController {
       ));
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setName($title)
-        ->setHref($this->getApplicationURI('/logs/')));
+    $crumbs->addTextCrumb($title, $this->getApplicationURI('/logs/'));
     $nav->setCrumbs($crumbs);
 
     return $this->buildApplicationPage(

src/applications/drydock/controller/DrydockResourceListController.php

@@ -20,10 +20,7 @@ final class DrydockResourceListController extends DrydockController {
     $resource_list = $this->buildResourceListView($resources);
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setName($title)
-        ->setHref($request->getRequestURI()));
+    $crumbs->addTextCrumb($title, $request->getRequestURI());
 
     $nav = $this->buildSideNav('resource');
     $nav->setCrumbs($crumbs);

src/applications/drydock/controller/DrydockResourceViewController.php

@@ -49,9 +49,7 @@ final class DrydockResourceViewController extends DrydockController {
 
     $crumbs = $this->buildApplicationCrumbs();
     $crumbs->setActionList($actions);
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Resource %d', $resource->getID())));
+    $crumbs->addTextCrumb(pht('Resource %d', $resource->getID()));
 
     $object_box = id(new PHUIObjectBoxView())
       ->setHeader($header)