Provide convenience method addTextCrumb() to PhabricatorCrumbsView
Summary: We currently have a lot of calls to `addCrumb(id(new PhabricatorCrumbView())->...)` which can be expressed much more simply with a convenience method. Nearly all crumbs are only textual. Test Plan: - This was mostly automated, then I cleaned up a few unusual sites manually. - Bunch of grep / randomly clicking around. Reviewers: btrahan, chad Reviewed By: btrahan CC: hach-que, aran Differential Revision: https://secure.phabricator.com/D7787
This commit is contained in:
@@ -667,15 +667,10 @@ final class ManiphestTaskEditController extends ManiphestController {
|
||||
$crumbs = $this->buildApplicationCrumbs();
|
||||
|
||||
if ($task->getID()) {
|
||||
$crumbs->addCrumb(
|
||||
id(new PhabricatorCrumbView())
|
||||
->setName('T'.$task->getID())
|
||||
->setHref('/T'.$task->getID()));
|
||||
$crumbs->addTextCrumb('T'.$task->getID(), '/T'.$task->getID());
|
||||
}
|
||||
|
||||
$crumbs->addCrumb(
|
||||
id(new PhabricatorCrumbView())
|
||||
->setName($header_name));
|
||||
$crumbs->addTextCrumb($header_name);
|
||||
|
||||
return $this->buildApplicationPage(
|
||||
array(
|
||||
|
||||
Reference in New Issue
Block a user