Provide convenience method addTextCrumb() to PhabricatorCrumbsView
Summary: We currently have a lot of calls to `addCrumb(id(new PhabricatorCrumbView())->...)` which can be expressed much more simply with a convenience method. Nearly all crumbs are only textual. Test Plan: - This was mostly automated, then I cleaned up a few unusual sites manually. - Bunch of grep / randomly clicking around. Reviewers: btrahan, chad Reviewed By: btrahan CC: hach-que, aran Differential Revision: https://secure.phabricator.com/D7787
This commit is contained in:
@@ -241,17 +241,12 @@ final class PhrictionEditController
|
||||
|
||||
$crumbs = $this->buildApplicationCrumbs();
|
||||
if ($document->getID()) {
|
||||
$crumbs->addCrumb(
|
||||
id(new PhabricatorCrumbView())
|
||||
->setName($content->getTitle())
|
||||
->setHref(PhrictionDocument::getSlugURI($document->getSlug())));
|
||||
$crumbs->addCrumb(
|
||||
id(new PhabricatorCrumbView())
|
||||
->setName(pht('Edit')));
|
||||
$crumbs->addTextCrumb(
|
||||
$content->getTitle(),
|
||||
PhrictionDocument::getSlugURI($document->getSlug()));
|
||||
$crumbs->addTextCrumb(pht('Edit'));
|
||||
} else {
|
||||
$crumbs->addCrumb(
|
||||
id(new PhabricatorCrumbView())
|
||||
->setName(pht('Create')));
|
||||
$crumbs->addTextCrumb(pht('Create'));
|
||||
}
|
||||
|
||||
return $this->buildApplicationPage(
|
||||
|
||||
Reference in New Issue
Block a user