Provide convenience method addTextCrumb() to PhabricatorCrumbsView
Summary: We currently have a lot of calls to `addCrumb(id(new PhabricatorCrumbView())->...)` which can be expressed much more simply with a convenience method. Nearly all crumbs are only textual. Test Plan: - This was mostly automated, then I cleaned up a few unusual sites manually. - Bunch of grep / randomly clicking around. Reviewers: btrahan, chad Reviewed By: btrahan CC: hach-que, aran Differential Revision: https://secure.phabricator.com/D7787
This commit is contained in:
@@ -111,15 +111,11 @@ final class PhabricatorProjectMembersEditController
|
||||
->setHeaderText($title)
|
||||
->setForm($form);
|
||||
|
||||
$crumbs = $this->buildApplicationCrumbs($this->buildSideNavView());
|
||||
$crumbs->addCrumb(
|
||||
id(new PhabricatorCrumbView())
|
||||
->setName($project->getName())
|
||||
->setHref('/project/view/'.$project->getID().'/'));
|
||||
$crumbs->addCrumb(
|
||||
id(new PhabricatorCrumbView())
|
||||
->setName(pht('Edit Members'))
|
||||
->setHref($this->getApplicationURI()));
|
||||
$crumbs = $this->buildApplicationCrumbs($this->buildSideNavView())
|
||||
->addTextCrumb(
|
||||
$project->getName(),
|
||||
'/project/view/'.$project->getID().'/')
|
||||
->addTextCrumb(pht('Edit Members'), $this->getApplicationURI());
|
||||
|
||||
return $this->buildApplicationPage(
|
||||
array(
|
||||
|
||||
Reference in New Issue
Block a user