archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Provide convenience method addTextCrumb() to PhabricatorCrumbsView

Browse Source 
Summary: We currently have a lot of calls to `addCrumb(id(new PhabricatorCrumbView())->...)` which can be expressed much more simply with a convenience method. Nearly all crumbs are only textual.

Test Plan:
  - This was mostly automated, then I cleaned up a few unusual sites manually.
  - Bunch of grep / randomly clicking around.

Reviewers: btrahan, chad

Reviewed By: btrahan

CC: hach-que, aran

Differential Revision: https://secure.phabricator.com/D7787
This commit is contained in:
epriestley
2013-12-18 17:47:34 -08:00
parent dc43123494
commit a5dc9067af
154 changed files with 304 additions and 770 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/applications/auth/controller/PhabricatorAuthConfirmLinkController.php
View File

@@ -70,13 +70,8 @@ final class PhabricatorAuthConfirmLinkController
$dialog->appendChild($form);
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Confirm Link'))
->setHref($panel_uri));
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($provider->getProviderName()));
$crumbs->addTextCrumb(pht('Confirm Link'), $panel_uri);
$crumbs->addTextCrumb($provider->getProviderName());
return $this->buildApplicationPage(
array(

9
src/applications/auth/controller/PhabricatorAuthLinkController.php
View File

@@ -115,13 +115,8 @@ final class PhabricatorAuthLinkController
}
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Link Account'))
->setHref($panel_uri));
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($provider->getProviderName($name)));
$crumbs->addTextCrumb(pht('Link Account'), $panel_uri);
$crumbs->addTextCrumb($provider->getProviderName($name));
return $this->buildApplicationPage(
array(

14
src/applications/auth/controller/PhabricatorAuthLoginController.php
View File

@@ -202,20 +202,12 @@ final class PhabricatorAuthLoginController
$crumbs = $this->buildApplicationCrumbs();
if ($this->getRequest()->getUser()->isLoggedIn()) {
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Link Account'))
->setHref($provider->getSettingsURI()));
$crumbs->addTextCrumb(pht('Link Account'), $provider->getSettingsURI());
} else {
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Login'))
->setHref($this->getApplicationURI('start/')));
$crumbs->addTextCrumb(pht('Login'), $this->getApplicationURI('start/'));
}
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($provider->getProviderName()));
$crumbs->addTextCrumb($provider->getProviderName());
return $this->buildApplicationPage(
array(

12
src/applications/auth/controller/PhabricatorAuthRegisterController.php
View File

@@ -401,17 +401,11 @@ final class PhabricatorAuthRegisterController
$crumbs = $this->buildApplicationCrumbs();
if ($is_setup) {
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Setup Admin Account')));
$crumbs->addTextCrumb(pht('Setup Admin Account'));
$title = pht('Welcome to Phabricator');
} else {
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Register')));
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($provider->getProviderName()));
$crumbs->addTextCrumb(pht('Register'));
$crumbs->addTextCrumb($provider->getProviderName());
$title = pht('Phabricator Registration');
}

4
src/applications/auth/controller/PhabricatorAuthStartController.php
View File

@@ -126,9 +126,7 @@ final class PhabricatorAuthStartController
$login_message = phutil_safe_html($login_message);
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Login')));
$crumbs->addTextCrumb(pht('Login'));
return $this->buildApplicationPage(
array(

4
src/applications/auth/controller/PhabricatorEmailLoginController.php
View File

@@ -133,9 +133,7 @@ EOBODY;
->setError($e_captcha));
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Reset Password')));
$crumbs->addTextCrumb(pht('Reset Password'));
$dialog = new AphrontDialogView();
$dialog->setUser($request->getUser());

4
src/applications/auth/controller/PhabricatorEmailVerificationController.php
View File

@@ -82,9 +82,7 @@ final class PhabricatorEmailVerificationController
->appendChild($content);
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Verify Email')));
$crumbs->addTextCrumb(pht('Verify Email'));
return $this->buildApplicationPage(
array(

4
src/applications/auth/controller/config/PhabricatorAuthEditController.php
View File

@@ -281,9 +281,7 @@ final class PhabricatorAuthEditController
}
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($crumb));
$crumbs->addTextCrumb($crumb);
$xaction_view = null;
if (!$is_new) {

4
src/applications/auth/controller/config/PhabricatorAuthListController.php
View File

@@ -86,9 +86,7 @@ final class PhabricatorAuthListController
pht('Add Authentication Provider'))));
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Auth Providers')));
$crumbs->addTextCrumb(pht('Auth Providers'));
$config_name = 'auth.email-domains';
$config_href = '/config/edit/'.$config_name.'/';

4
src/applications/auth/controller/config/PhabricatorAuthNewController.php
View File

@@ -87,9 +87,7 @@ final class PhabricatorAuthNewController
->setForm($form);
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Add Provider')));
$crumbs->addTextCrumb(pht('Add Provider'));
return $this->buildApplicationPage(
array(

5
src/applications/chatlog/controller/PhabricatorChatLogChannelListController.php
View File

@@ -23,10 +23,7 @@ final class PhabricatorChatLogChannelListController
$crumbs = $this
->buildApplicationCrumbs()
->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Channel List'))
->setHref($this->getApplicationURI()));
->addTextCrumb(pht('Channel List'), $this->getApplicationURI());
return $this->buildApplicationPage(
array(

5
src/applications/chatlog/controller/PhabricatorChatLogChannelLogController.php
View File

@@ -183,10 +183,7 @@ final class PhabricatorChatLogChannelLogController
$crumbs = $this
->buildApplicationCrumbs()
->addCrumb(
id(new PhabricatorCrumbView())
->setName($channel->getChannelName())
->setHref($uri));
->addTextCrumb($channel->getChannelName(), $uri);
$form = id(new AphrontFormView())
->setUser($user)

12
src/applications/conduit/controller/PhabricatorConduitAPIController.php
View File

@@ -380,15 +380,9 @@ final class PhabricatorConduitAPIController
$method_uri = $this->getApplicationURI('method/'.$method.'/');
$crumbs = $this->buildApplicationCrumbs();
$crumbs
->addCrumb(
id(new PhabricatorCrumbView())
->setName($method)
->setHref($method_uri))
->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Call')));
$crumbs = $this->buildApplicationCrumbs()
->addTextCrumb($method, $method_uri)
->addTextCrumb(pht('Call'));
return $this->buildApplicationPage(
array(

4
src/applications/conduit/controller/PhabricatorConduitConsoleController.php
View File

@@ -116,9 +116,7 @@ final class PhabricatorConduitConsoleController
->setForm($form);
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($method->getAPIMethodName()));
$crumbs->addTextCrumb($method->getAPIMethodName());
return $this->buildApplicationPage(
array(

4
src/applications/conduit/controller/PhabricatorConduitLogController.php
View File

@@ -40,9 +40,7 @@ final class PhabricatorConduitLogController
$table = $this->renderCallTable($calls, $conns);
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Call Logs')));
$crumbs->addTextCrumb(pht('Call Logs'));
return $this->buildApplicationPage(
array(

4
src/applications/conduit/controller/PhabricatorConduitTokenController.php
View File

@@ -49,9 +49,7 @@ final class PhabricatorConduitTokenController
->appendRemarkupInstructions($post_instructions);
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Install Certificate')));
$crumbs->addTextCrumb(pht('Install Certificate'));
$object_box = id(new PHUIObjectBoxView())
->setHeaderText(pht('Certificate Token'))

4
src/applications/config/controller/PhabricatorConfigAllController.php
View File

@@ -56,9 +56,7 @@ final class PhabricatorConfigAllController
$crumbs = $this
->buildApplicationCrumbs()
->addCrumb(
id(new PhabricatorCrumbView())
->setName($title));
->addTextCrumb($title);
$panel = new AphrontPanelView();
$panel->appendChild($table);

15
src/applications/config/controller/PhabricatorConfigEditController.php
View File

@@ -199,22 +199,13 @@ final class PhabricatorConfigEditController
->setForm($form);
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Config'))
->setHref($this->getApplicationURI()));
$crumbs->addTextCrumb(pht('Config'), $this->getApplicationURI());
if ($group) {
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($group->getName())
->setHref($group_uri));
$crumbs->addTextCrumb($group->getName(), $group_uri);
}
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($this->key)
->setHref('/config/edit/'.$this->key));
$crumbs->addTextCrumb($this->key, '/config/edit/'.$this->key);
$xactions = id(new PhabricatorConfigTransactionQuery())
->withObjectPHIDs(array($config_entry->getPHID()))

10
src/applications/config/controller/PhabricatorConfigGroupController.php
View File

@@ -28,14 +28,8 @@ final class PhabricatorConfigGroupController
$crumbs = $this
->buildApplicationCrumbs()
->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Config'))
->setHref($this->getApplicationURI()))
->addCrumb(
id(new PhabricatorCrumbView())
->setName($options->getName())
->setHref($this->getApplicationURI()));
->addTextCrumb(pht('Config'), $this->getApplicationURI())
->addTextCrumb($options->getName(), $this->getApplicationURI());
return $this->buildApplicationPage(
array(

5
src/applications/config/controller/PhabricatorConfigIssueListController.php
View File

@@ -30,10 +30,7 @@ final class PhabricatorConfigIssueListController
$crumbs = $this
->buildApplicationCrumbs($nav)
->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Setup'))
->setHref($this->getApplicationURI('issue/')));
->addTextCrumb(pht('Setup'), $this->getApplicationURI('issue/'));
$nav->setCrumbs($crumbs);

10
src/applications/config/controller/PhabricatorConfigIssueViewController.php
View File

@@ -38,14 +38,8 @@ final class PhabricatorConfigIssueViewController
$crumbs = $this
->buildApplicationCrumbs()
->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Setup Issues'))
->setHref($this->getApplicationURI('issue/')))
->addCrumb(
id(new PhabricatorCrumbView())
->setName($title)
->setHref($request->getRequestURI()));
->addTextCrumb(pht('Setup Issues'), $this->getApplicationURI('issue/'))
->addTextCrumb($title, $request->getRequestURI());
return $this->buildApplicationPage(
array(

5
src/applications/config/controller/PhabricatorConfigListController.php
View File

@@ -26,10 +26,7 @@ final class PhabricatorConfigListController
$crumbs = $this
->buildApplicationCrumbs()
->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Config'))
->setHref($this->getApplicationURI()));
->addTextCrumb(pht('Config'), $this->getApplicationURI());
$nav->setCrumbs($crumbs);

13
src/applications/countdown/controller/PhabricatorCountdownEditController.php
View File

@@ -90,18 +90,11 @@ final class PhabricatorCountdownEditController
$cancel_uri = '/countdown/';
if ($countdown->getID()) {
$cancel_uri = '/countdown/'.$countdown->getID().'/';
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName('C'.$countdown->getID())
->setHref($cancel_uri));
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Edit')));
$crumbs->addTextCrumb('C'.$countdown->getID(), $cancel_uri);
$crumbs->addTextCrumb(pht('Edit'));
$submit_label = pht('Save Changes');
} else {
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Create Countdown')));
$crumbs->addTextCrumb(pht('Create Countdown'));
$submit_label = pht('Create Countdown');
}

4
src/applications/countdown/controller/PhabricatorCountdownViewController.php
View File

@@ -36,9 +36,7 @@ final class PhabricatorCountdownViewController
$crumbs = $this
->buildApplicationCrumbs()
->addCrumb(
id(new PhabricatorCrumbView())
->setName("C{$id}"));
->addTextCrumb("C{$id}");
$header = id(new PHUIHeaderView())
->setHeader($title)

4
src/applications/daemon/controller/PhabricatorDaemonConsoleController.php
View File

@@ -211,9 +211,7 @@ final class PhabricatorDaemonConsoleController
$queued_panel->setNoBackground();
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Console')));
$crumbs->addTextCrumb(pht('Console'));
$nav = $this->buildSideNavView();
$nav->selectFilter('/');

13
src/applications/daemon/controller/PhabricatorDaemonLogEventViewController.php
View File

@@ -29,14 +29,11 @@ final class PhabricatorDaemonLogEventViewController
$daemon_id = $event->getLogID();
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Daemon %s', $daemon_id))
->setHref($this->getApplicationURI("log/{$daemon_id}/")));
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Event %s', $event->getID())));
$crumbs = $this->buildApplicationCrumbs()
->addTextCrumb(
pht('Daemon %s', $daemon_id),
$this->getApplicationURI("log/{$daemon_id}/"))
->addTextCrumb(pht('Event %s', $event->getID()));
return $this->buildApplicationPage(

4
src/applications/daemon/controller/PhabricatorDaemonLogListController.php
View File

@@ -19,9 +19,7 @@ final class PhabricatorDaemonLogListController
$daemon_table->setDaemonLogs($logs);
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('All Daemons')));
$crumbs->addTextCrumb(pht('All Daemons'));
$nav = $this->buildSideNavView();
$nav->selectFilter('log');

4
src/applications/daemon/controller/PhabricatorDaemonLogViewController.php
View File

@@ -26,9 +26,7 @@ final class PhabricatorDaemonLogViewController
$log->getID());
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Daemon %s', $log->getID())));
$crumbs->addTextCrumb(pht('Daemon %s', $log->getID()));
$header = id(new PHUIHeaderView())
->setHeader($log->getDaemon());

4
src/applications/daemon/controller/PhabricatorWorkerTaskDetailController.php
View File

@@ -58,9 +58,7 @@ final class PhabricatorWorkerTaskDetailController
}
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($title));
$crumbs->addTextCrumb($title);
return $this->buildApplicationPage(
array(

4
src/applications/differential/controller/DifferentialDiffCreateController.php
View File

@@ -88,9 +88,7 @@ final class DifferentialDiffCreateController extends DifferentialController {
->setForm($form);
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Create Diff')));
$crumbs->addTextCrumb(pht('Create Diff'));
if ($errors) {
$errors = id(new AphrontErrorView())

4
src/applications/differential/controller/DifferentialDiffViewController.php
View File

@@ -146,9 +146,7 @@ final class DifferentialDiffViewController extends DifferentialController {
->setUser($request->getUser());
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Diff %d', $diff->getID())));
$crumbs->addTextCrumb(pht('Diff %d', $diff->getID()));
return $this->buildApplicationPage(
array(

18
src/applications/differential/controller/DifferentialRevisionEditController.php
View File

@@ -153,16 +153,14 @@ final class DifferentialRevisionEditController extends DifferentialController {
if ($revision->getID()) {
if ($diff) {
$title = pht('Update Differential Revision');
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName('D'.$revision->getID())
->setHref('/differential/diff/'.$diff->getID().'/'));
$crumbs->addTextCrumb(
'D'.$revision->getID(),
'/differential/diff/'.$diff->getID().'/');
} else {
$title = pht('Edit Differential Revision');
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName('D'.$revision->getID())
->setHref('/D'.$revision->getID()));
$crumbs->addTextCrumb(
'D'.$revision->getID(),
'/D'.$revision->getID());
}
} else {
$title = pht('Create New Differential Revision');
@@ -173,9 +171,7 @@ final class DifferentialRevisionEditController extends DifferentialController {
->setFormError($error_view)
->setForm($form);
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($title));
$crumbs->addTextCrumb($title);
return $this->buildApplicationPage(
array(

5
src/applications/differential/controller/DifferentialRevisionViewController.php
View File

@@ -421,10 +421,7 @@ final class DifferentialRevisionViewController extends DifferentialController {
);
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($object_id)
->setHref('/'.$object_id));
$crumbs->addTextCrumb($object_id, '/'.$object_id);
$prefs = $user->loadPreferences();

4
src/applications/diffusion/controller/DiffusionLintController.php
View File

@@ -139,9 +139,7 @@ final class DiffusionLintController extends DiffusionController {
if ($this->diffusionRequest) {
$title[] = $drequest->getCallsign();
} else {
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('All Lint')));
$crumbs->addTextCrumb(pht('All Lint'));
}
if ($this->diffusionRequest) {

4
src/applications/diffusion/controller/DiffusionRepositoryCreateController.php
View File

@@ -181,9 +181,7 @@ final class DiffusionRepositoryCreateController
}
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($title));
$crumbs->addTextCrumb($title);
return $this->buildApplicationPage(
array(

4
src/applications/diffusion/controller/DiffusionRepositoryEditActionsController.php
View File

@@ -59,9 +59,7 @@ final class DiffusionRepositoryEditActionsController
$content = array();
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Edit Actions')));
$crumbs->addTextCrumb(pht('Edit Actions'));
$title = pht('Edit Actions (%s)', $repository->getName());

4
src/applications/diffusion/controller/DiffusionRepositoryEditBasicController.php
View File

@@ -67,9 +67,7 @@ final class DiffusionRepositoryEditBasicController
}
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Edit Basics')));
$crumbs->addTextCrumb(pht('Edit Basics'));
$title = pht('Edit %s', $repository->getName());

4
src/applications/diffusion/controller/DiffusionRepositoryEditBranchesController.php
View File

@@ -88,9 +88,7 @@ final class DiffusionRepositoryEditBranchesController
$content = array();
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Edit Branches')));
$crumbs->addTextCrumb(pht('Edit Branches'));
$title = pht('Edit Branches (%s)', $repository->getName());

14
src/applications/diffusion/controller/DiffusionRepositoryEditController.php
View File

@@ -11,20 +11,12 @@ abstract class DiffusionRepositoryEditController
$repo_uri = $this->getRepositoryControllerURI($repository, '');
$edit_uri = $this->getRepositoryControllerURI($repository, 'edit/');
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName('r'.$repository->getCallsign())
->setHref($repo_uri));
$crumbs->addTextCrumb('r'.$repository->getCallsign(), $repo_uri);
if ($is_main) {
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Edit Repository')));
$crumbs->addTextCrumb(pht('Edit Repository'));
} else {
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Edit'))
->setHref($edit_uri));
$crumbs->addTextCrumb(pht('Edit'), $edit_uri);
}
}

4
src/applications/diffusion/controller/DiffusionRepositoryEditEncodingController.php
View File

@@ -57,9 +57,7 @@ final class DiffusionRepositoryEditEncodingController
}
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Edit Encoding')));
$crumbs->addTextCrumb(pht('Edit Encoding'));
$title = pht('Edit %s', $repository->getName());

8
src/applications/diffusion/controller/DiffusionRepositoryEditHostingController.php
View File

@@ -67,9 +67,7 @@ final class DiffusionRepositoryEditHostingController
}
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Edit Hosting')));
$crumbs->addTextCrumb(pht('Edit Hosting'));
$title = pht('Edit Hosting (%s)', $repository->getName());
@@ -172,9 +170,7 @@ final class DiffusionRepositoryEditHostingController
}
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Edit Protocols')));
$crumbs->addTextCrumb(pht('Edit Protocols'));
$title = pht('Edit Protocols (%s)', $repository->getName());

4
src/applications/diffusion/controller/DiffusionRepositoryEditLocalController.php
View File

@@ -29,9 +29,7 @@ final class DiffusionRepositoryEditLocalController
$errors = array();
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Edit Local')));
$crumbs->addTextCrumb(pht('Edit Local'));
$title = pht('Edit %s', $repository->getName());

4
src/applications/diffusion/controller/DiffusionRepositoryEditPolicyController.php
View File

@@ -67,9 +67,7 @@ final class DiffusionRepositoryEditPolicyController
$content = array();
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Edit Policies')));
$crumbs->addTextCrumb(pht('Edit Policies'));
$title = pht('Edit Policies (%s)', $repository->getName());

4
src/applications/diffusion/controller/DiffusionRepositoryEditSubversionController.php
View File

@@ -70,9 +70,7 @@ final class DiffusionRepositoryEditSubversionController
$content = array();
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Edit Subversion Info')));
$crumbs->addTextCrumb(pht('Edit Subversion Info'));
$title = pht('Edit Subversion Info (%s)', $repository->getName());

4
src/applications/diffusion/controller/DiffusionRepositoryNewController.php
View File

@@ -67,9 +67,7 @@ final class DiffusionRepositoryNewController
->addCancelButton($this->getApplicationURI()));
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('New Repository')));
$crumbs->addTextCrumb(pht('New Repository'));
$form_box = id(new PHUIObjectBoxView())
->setHeaderText(pht('Create or Import Repository'))

11
src/applications/diviner/controller/DivinerAtomController.php
View File

@@ -59,18 +59,15 @@ final class DivinerAtomController extends DivinerController {
$atom = $symbol->getAtom();
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($book->getShortTitle())
->setHref('/book/'.$book->getName().'/'));
$crumbs->addTextCrumb(
$book->getShortTitle(),
'/book/'.$book->getName().'/');
$atom_short_title = $atom->getDocblockMetaValue(
'short',
$symbol->getTitle());
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($atom_short_title));
$crumbs->addTextCrumb($atom_short_title);
$header = id(new PHUIHeaderView())
->setHeader($this->renderFullSignature($symbol))

7
src/applications/diviner/controller/DivinerBookController.php
View File

@@ -27,10 +27,9 @@ final class DivinerBookController extends DivinerController {
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($book->getShortTitle())
->setHref('/book/'.$book->getName().'/'));
$crumbs->addTextCrumb(
$book->getShortTitle(),
'/book/'.$book->getName().'/');
$header = id(new PHUIHeaderView())
->setHeader($book->getTitle())

4
src/applications/diviner/controller/DivinerLegacyController.php
View File

@@ -43,9 +43,7 @@ final class DivinerLegacyController extends DivinerController {
}
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Documentation')));
$crumbs->addTextCrumb(pht('Documentation'));
$header = id(new PHUIHeaderView())
->setHeader(pht('Documentation'));

8
src/applications/drydock/controller/DrydockBlueprintEditController.php
View File

@@ -80,12 +80,8 @@ final class DrydockBlueprintEditController extends DrydockController {
$title = pht('Edit Blueprint');
$header = pht('Edit Blueprint %d', $blueprint->getID());
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Blueprint %d', $blueprint->getID())));
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Edit')));
$crumbs->addTextCrumb(pht('Blueprint %d', $blueprint->getID()));
$crumbs->addTextCrumb(pht('Edit'));
if ($request->isAjax()) {
$dialog = id(new AphrontDialogView())

5
src/applications/drydock/controller/DrydockBlueprintListController.php
View File

@@ -18,10 +18,7 @@ final class DrydockBlueprintListController extends DrydockController {
$blueprint_list = $this->buildBlueprintListView($blueprints);
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($title)
->setHref($request->getRequestURI()));
$crumbs->addTextCrumb($title, $request->getRequestURI());
$crumbs->addAction(
id(new PHUIListItemView())

4
src/applications/drydock/controller/DrydockBlueprintViewController.php
View File

@@ -42,9 +42,7 @@ final class DrydockBlueprintViewController extends DrydockController {
$crumbs = $this->buildApplicationCrumbs();
$crumbs->setActionList($actions);
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Blueprint %d', $blueprint->getID())));
$crumbs->addTextCrumb(pht('Blueprint %d', $blueprint->getID()));
$object_box = id(new PHUIObjectBoxView())
->setHeader($header)

5
src/applications/drydock/controller/DrydockLeaseListController.php
View File

@@ -31,10 +31,7 @@ final class DrydockLeaseListController extends DrydockController {
));
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($title)
->setHref($request->getRequestURI()));
$crumbs->addTextCrumb($title, $request->getRequestURI());
$nav->setCrumbs($crumbs);
return $this->buildApplicationPage(

5
src/applications/drydock/controller/DrydockLeaseViewController.php
View File

@@ -40,10 +40,7 @@ final class DrydockLeaseViewController extends DrydockController {
$crumbs = $this->buildApplicationCrumbs();
$crumbs->setActionList($actions);
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($title)
->setHref($lease_uri));
$crumbs->addTextCrumb($title, $lease_uri);
$object_box = id(new PHUIObjectBoxView())
->setHeader($header)

5
src/applications/drydock/controller/DrydockLogController.php
View File

@@ -43,10 +43,7 @@ final class DrydockLogController extends DrydockController {
));
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($title)
->setHref($this->getApplicationURI('/logs/')));
$crumbs->addTextCrumb($title, $this->getApplicationURI('/logs/'));
$nav->setCrumbs($crumbs);
return $this->buildApplicationPage(

5
src/applications/drydock/controller/DrydockResourceListController.php
View File

@@ -20,10 +20,7 @@ final class DrydockResourceListController extends DrydockController {
$resource_list = $this->buildResourceListView($resources);
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($title)
->setHref($request->getRequestURI()));
$crumbs->addTextCrumb($title, $request->getRequestURI());
$nav = $this->buildSideNav('resource');
$nav->setCrumbs($crumbs);

4
src/applications/drydock/controller/DrydockResourceViewController.php
View File

@@ -49,9 +49,7 @@ final class DrydockResourceViewController extends DrydockController {
$crumbs = $this->buildApplicationCrumbs();
$crumbs->setActionList($actions);
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Resource %d', $resource->getID())));
$crumbs->addTextCrumb(pht('Resource %d', $resource->getID()));
$object_box = id(new PHUIObjectBoxView())
->setHeader($header)

4
src/applications/feed/controller/PhabricatorFeedDetailController.php
View File

@@ -30,9 +30,7 @@ final class PhabricatorFeedDetailController extends PhabricatorFeedController {
$feed_view = phutil_tag_div('phabricator-feed-frame', $feed_view);
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($title));
$crumbs->addTextCrumb($title);
return $this->buildApplicationPage(

7
src/applications/files/controller/PhabricatorFileInfoController.php
View File

@@ -47,10 +47,9 @@ final class PhabricatorFileInfoController extends PhabricatorFileController {
$timeline = $this->buildTransactionView($file, $xactions);
$crumbs = $this->buildApplicationCrumbs();
$crumbs->setActionList($actions);
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName('F'.$file->getID())
->setHref($this->getApplicationURI("/info/{$phid}/")));
$crumbs->addTextCrumb(
'F'.$file->getID(),
$this->getApplicationURI("/info/{$phid}/"));
$object_box = id(new PHUIObjectBoxView())
->setHeader($header);

5
src/applications/files/controller/PhabricatorFileUploadController.php
View File

@@ -60,10 +60,7 @@ final class PhabricatorFileUploadController extends PhabricatorFileController {
->appendChild($instructions);
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Upload'))
->setHref($request->getRequestURI()));
$crumbs->addTextCrumb(pht('Upload'), $request->getRequestURI());
$title = pht('Upload File');

4
src/applications/harbormaster/controller/HarbormasterBuildViewController.php
View File

@@ -37,9 +37,7 @@ final class HarbormasterBuildViewController
$this->buildPropertyLists($box, $build, $actions);
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($title));
$crumbs->addTextCrumb($title);
$build_targets = id(new HarbormasterBuildTargetQuery())
->setViewer($viewer)

13
src/applications/harbormaster/controller/HarbormasterBuildableEditController.php
View File

@@ -119,18 +119,11 @@ final class HarbormasterBuildableEditController
$crumbs = $this->buildApplicationCrumbs();
if ($is_new) {
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('New Buildable')));
$crumbs->addTextCrumb(pht('New Buildable'));
} else {
$id = $buildable->getID();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName("B{$id}")
->setHref("/B{$id}"));
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Edit')));
$crumbs->addTextCrumb("B{$id}", "/B{$id}");
$crumbs->addTextCrumb(pht('Edit'));
}
return $this->buildApplicationPage(

4
src/applications/harbormaster/controller/HarbormasterBuildableViewController.php
View File

@@ -94,9 +94,7 @@ final class HarbormasterBuildableViewController
$this->buildPropertyLists($box, $buildable, $actions);
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName("B{$id}"));
$crumbs->addTextCrumb("B{$id}");
return $this->buildApplicationPage(
array(

7
src/applications/harbormaster/controller/HarbormasterPlanController.php
View File

@@ -5,10 +5,9 @@ abstract class HarbormasterPlanController extends PhabricatorController {
public function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Build Plans'))
->setHref($this->getApplicationURI('plan/')));
$crumbs->addTextCrumb(
pht('Build Plans'),
$this->getApplicationURI('plan/'));
return $crumbs;
}

15
src/applications/harbormaster/controller/HarbormasterPlanEditController.php
View File

@@ -93,18 +93,13 @@ final class HarbormasterPlanEditController
$crumbs = $this->buildApplicationCrumbs();
if ($is_new) {
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('New Build Plan')));
$crumbs->addTextCrumb(pht('New Build Plan'));
} else {
$id = $plan->getID();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht("Plan %d", $id))
->setHref($this->getApplicationURI("plan/{$id}/")));
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Edit')));
$crumbs->addTextCrumb(
pht("Plan %d", $id),
$this->getApplicationURI("plan/{$id}/"));
$crumbs->addTextCrumb(pht('Edit'));
}
return $this->buildApplicationPage(

4
src/applications/harbormaster/controller/HarbormasterPlanViewController.php
View File

@@ -51,9 +51,7 @@ final class HarbormasterPlanViewController
$this->buildPropertyLists($box, $plan, $actions);
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht("Plan %d", $id)));
$crumbs->addTextCrumb(pht("Plan %d", $id));
$step_list = $this->buildStepList($plan);

11
src/applications/harbormaster/controller/HarbormasterStepEditController.php
View File

@@ -132,13 +132,10 @@ final class HarbormasterStepEditController
$crumbs = $this->buildApplicationCrumbs();
$id = $plan->getID();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht("Plan %d", $id))
->setHref($this->getApplicationURI("plan/{$id}/")));
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Edit Step')));
$crumbs->addTextCrumb(
pht("Plan %d", $id),
$this->getApplicationURI("plan/{$id}/"));
$crumbs->addTextCrumb(pht('Edit Step'));
return $this->buildApplicationPage(
array(

4
src/applications/herald/controller/HeraldNewController.php
View File

@@ -89,9 +89,7 @@ final class HeraldNewController extends HeraldController {
$crumbs = $this
->buildApplicationCrumbs()
->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Create Rule')));
->addTextCrumb(pht('Create Rule'));
return $this->buildApplicationPage(
array(

4
src/applications/herald/controller/HeraldRuleController.php
View File

@@ -194,9 +194,7 @@ final class HeraldRuleController extends HeraldController {
$crumbs = $this
->buildApplicationCrumbs()
->addCrumb(
id(new PhabricatorCrumbView())
->setName($title));
->addTextCrumb($title);
return $this->buildApplicationPage(
array(

7
src/applications/herald/controller/HeraldRuleEditHistoryController.php
View File

@@ -37,10 +37,9 @@ final class HeraldRuleEditHistoryController extends HeraldController {
$crumbs = $this
->buildApplicationCrumbs($can_create = false)
->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Edit History'))
->setHref($this->getApplicationURI('herald/history')));
->addTextCrumb(
pht('Edit History'),
$this->getApplicationURI('herald/history'));
$nav = $this->buildSideNavView();
$nav->selectFilter('history');

4
src/applications/herald/controller/HeraldRuleViewController.php
View File

@@ -44,9 +44,7 @@ final class HeraldRuleViewController extends HeraldController {
$id = $rule->getID();
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName("H{$id}"));
$crumbs->addTextCrumb("H{$id}");
$object_box = id(new PHUIObjectBoxView())
->setHeader($header)

11
src/applications/herald/controller/HeraldTestConsoleController.php
View File

@@ -112,13 +112,10 @@ final class HeraldTestConsoleController extends HeraldController {
->setForm($form);
$crumbs = id($this->buildApplicationCrumbs())
->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Transcripts'))
->setHref($this->getApplicationURI('/transcript/')))
->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Test Console')));
->addTextCrumb(
pht('Transcripts'),
$this->getApplicationURI('/transcript/'))
->addTextCrumb(pht('Test Console'));
return $this->buildApplicationPage(
$box,

11
src/applications/herald/controller/HeraldTranscriptController.php
View File

@@ -97,13 +97,10 @@ final class HeraldTranscriptController extends HeraldController {
}
$crumbs = id($this->buildApplicationCrumbs())
->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Transcripts'))
->setHref($this->getApplicationURI('/transcript/')))
->addCrumb(
id(new PhabricatorCrumbView())
->setName($xscript->getID()));
->addTextCrumb(
pht('Transcripts'),
$this->getApplicationURI('/transcript/'))
->addTextCrumb($xscript->getID());
$nav->setCrumbs($crumbs);
return $this->buildApplicationPage(

4
src/applications/herald/controller/HeraldTranscriptListController.php
View File

@@ -72,9 +72,7 @@ final class HeraldTranscriptListController extends HeraldController {
$nav->appendChild($panel);
$crumbs = id($this->buildApplicationCrumbs())
->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Transcripts')));
->addTextCrumb(pht('Transcripts'));
$nav->setCrumbs($crumbs);
return $this->buildApplicationPage(

3
src/applications/legalpad/controller/LegalpadDocumentEditController.php
View File

@@ -173,8 +173,7 @@ final class LegalpadDocumentEditController extends LegalpadController {
->setForm($form);
$crumbs = $this->buildApplicationCrumbs($this->buildSideNav());
$crumbs->addCrumb(
id(new PhabricatorCrumbView())->setName($short));
$crumbs->addTextCrumb($short);
$preview = id(new PHUIRemarkupPreviewPanel())

7
src/applications/legalpad/controller/LegalpadDocumentViewController.php
View File

@@ -81,10 +81,9 @@ final class LegalpadDocumentViewController extends LegalpadController {
$crumbs = $this->buildApplicationCrumbs($this->buildSideNav());
$crumbs->setActionList($actions);
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName('L'.$document->getID())
->setHref($this->getApplicationURI('view/'.$document->getID())));
$crumbs->addTextCrumb(
'L'.$document->getID(),
$this->getApplicationURI('view/'.$document->getID()));
$object_box = id(new PHUIObjectBoxView())
->setHeader($header)

11
src/applications/macro/controller/PhabricatorMacroAudioController.php
View File

@@ -132,15 +132,8 @@ final class PhabricatorMacroAudioController
$title = pht('Edit Audio Behavior');
$crumb = pht('Edit Audio');
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setHref($view_uri)
->setName(pht('Macro "%s"', $macro->getName())));
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setHref($request->getRequestURI())
->setName($crumb));
$crumbs->addTextCrumb(pht('Macro "%s"', $macro->getName()), $view_uri);
$crumbs->addTextCrumb($crumb, $request->getRequestURI());
$upload_form = id(new AphrontFormView())
->setEncType('multipart/form-data')

10
src/applications/macro/controller/PhabricatorMacroEditController.php
View File

@@ -219,19 +219,13 @@ final class PhabricatorMacroEditController
$title = pht('Edit Image Macro');
$crumb = pht('Edit Macro');
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setHref($view_uri)
->setName(pht('Macro "%s"', $macro->getName())));
$crumbs->addTextCrumb(pht('Macro "%s"', $macro->getName()), $view_uri);
} else {
$title = pht('Create Image Macro');
$crumb = pht('Create Macro');
}
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setHref($request->getRequestURI())
->setName($crumb));
$crumbs->addCrumb($crumb, $request->getRequestURI());
$upload = null;
if ($macro->getID()) {

7
src/applications/macro/controller/PhabricatorMacroViewController.php
View File

@@ -30,10 +30,9 @@ final class PhabricatorMacroViewController
$crumbs = $this->buildApplicationCrumbs();
$crumbs->setActionList($actions);
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setHref($this->getApplicationURI('/view/'.$macro->getID().'/'))
->setName($title_short));
$crumbs->addTextCrumb(
$title_short,
$this->getApplicationURI('/view/'.$macro->getID().'/'));
$properties = $this->buildPropertyView($macro, $actions);
if ($file) {

8
src/applications/mailinglists/controller/PhabricatorMailingListsEditController.php
View File

@@ -117,13 +117,9 @@ final class PhabricatorMailingListsEditController
->addCancelButton($this->getApplicationURI()));
if ($list->getID()) {
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Edit Mailing List')));
$crumbs->addTextCrumb(pht('Edit Mailing List'));
} else {
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Create Mailing List')));
$crumbs->addTextCrumb(pht('Create Mailing List'));
}
$form_box = id(new PHUIObjectBoxView())

4
src/applications/maniphest/controller/ManiphestBatchEditController.php
View File

@@ -144,9 +144,7 @@ final class ManiphestBatchEditController extends ManiphestController {
$title = pht('Batch Editor');
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($title));
$crumbs->addTextCrumb($title);
$form_box = id(new PHUIObjectBoxView())
->setHeaderText(pht('Batch Edit Tasks'))

4
src/applications/maniphest/controller/ManiphestReportController.php
View File

@@ -55,9 +55,7 @@ final class ManiphestReportController extends ManiphestController {
$nav->appendChild($core);
$nav->setCrumbs(
$this->buildApplicationCrumbs()
->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Reports'))));
->addTextCrumb(pht('Reports')));
return $this->buildApplicationPage(
$nav,

7
src/applications/maniphest/controller/ManiphestTaskDetailController.php
View File

@@ -367,11 +367,8 @@ final class ManiphestTaskDetailController extends ManiphestController {
$object_name = 'T'.$task->getID();
$actions = $this->buildActionView($task);
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($object_name)
->setHref('/'.$object_name))
$crumbs = $this->buildApplicationCrumbs()
->addTextCrumb($object_name, '/'.$object_name)
->setActionList($actions);
$header = $this->buildHeaderView($task);

9
src/applications/maniphest/controller/ManiphestTaskEditController.php
View File

@@ -667,15 +667,10 @@ final class ManiphestTaskEditController extends ManiphestController {
$crumbs = $this->buildApplicationCrumbs();
if ($task->getID()) {
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName('T'.$task->getID())
->setHref('/T'.$task->getID()));
$crumbs->addTextCrumb('T'.$task->getID(), '/T'.$task->getID());
}
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($header_name));
$crumbs->addTextCrumb($header_name);
return $this->buildApplicationPage(
array(

4
src/applications/meta/controller/PhabricatorApplicationDetailViewController.php
View File

@@ -24,9 +24,7 @@ final class PhabricatorApplicationDetailViewController
$title = $selected->getName();
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($selected->getName()));
$crumbs->addTextCrumb($selected->getName());
$header = id(new PHUIHeaderView())
->setHeader($title)

9
src/applications/meta/controller/PhabricatorApplicationEditController.php
View File

@@ -146,13 +146,8 @@ final class PhabricatorApplicationEditController
->addCancelButton($view_uri));
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($application->getName())
->setHref($view_uri));
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Edit Policies')));
$crumbs->addTextCrumb($application->getName(), $view_uri);
$crumbs->addTextCrumb(pht('Edit Policies'));
$header = id(new PHUIHeaderView())
->setHeader(pht('Edit Policies: %s', $application->getName()));

4
src/applications/nuance/controller/NuanceSourceViewController.php
View File

@@ -47,9 +47,7 @@ final class NuanceSourceViewController extends NuanceController {
$title = pht('%s', $source->getName());
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($title));
$crumbs->addTextCrumb($title);
$header = $this->buildHeaderView($source);
$actions = $this->buildActionView($source);

4
src/applications/owners/controller/PhabricatorOwnersController.php
View File

@@ -45,9 +45,7 @@ abstract class PhabricatorOwnersController extends PhabricatorController {
}
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($title));
$crumbs->addTextCrumb($title);
$crumbs->addAction(
id(new PHUIListItemView())

4
src/applications/passphrase/controller/PassphraseCredentialCreateController.php
View File

@@ -55,9 +55,7 @@ final class PassphraseCredentialCreateController extends PassphraseController {
$title = pht('New Credential');
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Create')));
$crumbs->addTextCrumb(pht('Create'));
$box = id(new PHUIObjectBoxView())
->setHeaderText(pht('Create New Credential'))

15
src/applications/passphrase/controller/PassphraseCredentialEditController.php
View File

@@ -219,19 +219,14 @@ final class PassphraseCredentialEditController extends PassphraseController {
if ($is_new) {
$title = pht('Create Credential');
$header = pht('Create New Credential');
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Create')));
$crumbs->addTextCrumb(pht('Create'));
} else {
$title = pht('Edit Credential');
$header = pht('Edit Credential %s', 'K'.$credential->getID());
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName('K'.$credential->getID())
->setHref('/K'.$credential->getID()));
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Edit')));
$crumbs->addTextCrumb(
'K'.$credential->getID(),
'/K'.$credential->getID());
$crumbs->addTextCrumb(pht('Edit'));
}
if ($request->isAjax()) {

4
src/applications/passphrase/controller/PassphraseCredentialViewController.php
View File

@@ -41,9 +41,7 @@ final class PassphraseCredentialViewController extends PassphraseController {
$title = pht('%s %s', 'K'.$credential->getID(), $credential->getName());
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName('K'.$credential->getID()));
$crumbs->addTextCrumb('K'.$credential->getID());
$header = $this->buildHeaderView($credential);
$actions = $this->buildActionView($credential);

8
src/applications/paste/controller/PhabricatorPasteEditController.php
View File

@@ -212,13 +212,9 @@ final class PhabricatorPasteEditController extends PhabricatorPasteController {
$crumbs = $this->buildApplicationCrumbs($this->buildSideNavView());
if (!$is_create) {
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName('P'.$paste->getID())
->setHref('/P'.$paste->getID()));
$crumbs->addTextCrumb('P'.$paste->getID(), '/P'.$paste->getID());
}
$crumbs->addCrumb(
id(new PhabricatorCrumbView())->setName($short));
$crumbs->addTextCrumb($short);
return $this->buildApplicationPage(
array(

5
src/applications/paste/controller/PhabricatorPasteViewController.php
View File

@@ -88,10 +88,7 @@ final class PhabricatorPasteViewController extends PhabricatorPasteController {
$crumbs = $this->buildApplicationCrumbs($this->buildSideNavView())
->setActionList($actions)
->addCrumb(
id(new PhabricatorCrumbView())
->setName('P'.$paste->getID())
->setHref('/P'.$paste->getID()));
->addTextCrumb('P'.$paste->getID(), '/P'.$paste->getID());
$xactions = id(new PhabricatorPasteTransactionQuery())
->setViewer($request->getUser())

15
src/applications/people/controller/PhabricatorPeopleEditController.php
View File

@@ -23,21 +23,12 @@ final class PhabricatorPeopleEditController
return new Aphront404Response();
}
$base_uri = '/people/edit/'.$user->getID().'/';
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Edit User'))
->setHref('/people/edit/'));
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($user->getFullName())
->setHref($base_uri));
$crumbs->addTextCrumb(pht('Edit User'), '/people/edit/');
$crumbs->addTextCrumb($user->getFullName(), $base_uri);
} else {
$user = new PhabricatorUser();
$base_uri = '/people/edit/';
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Create New User'))
->setHref($base_uri));
$crumbs->addTextCrumb(pht('Create New User'), $base_uri);
}
$nav = new AphrontSideNavFilterView();

7
src/applications/people/controller/PhabricatorPeopleLdapController.php
View File

@@ -38,10 +38,9 @@ final class PhabricatorPeopleLdapController
->appendChild($form);
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Import Ldap Users'))
->setHref($this->getApplicationURI('/ldap/')));
$crumbs->addTextCrumb(
pht('Import Ldap Users'),
$this->getApplicationURI('/ldap/'));
$nav = $this->buildSideNavView();
$nav->setCrumbs($crumbs);

5
src/applications/people/controller/PhabricatorPeopleLogsController.php
View File

@@ -207,10 +207,7 @@ final class PhabricatorPeopleLogsController
$filter = new AphrontListFilterView();
$filter->appendChild($form);
$crumbs = $this->buildApplicationCrumbs($this->buildSideNavView());
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Activity Logs'))
->setHref('/people/logs/'));
$crumbs->addTextCrumb(pht('Activity Logs'), '/people/logs/');
$nav = $this->buildSideNavView();
$nav->selectFilter('logs');

4
src/applications/people/controller/PhabricatorPeopleProfileController.php
View File

@@ -71,9 +71,7 @@ final class PhabricatorPeopleProfileController
$properties = $this->buildPropertyView($user, $actions);
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($user->getUsername()));
$crumbs->addTextCrumb($user->getUsername());
$feed = $this->renderUserFeed($user);
$object_box = id(new PHUIObjectBoxView())

9
src/applications/people/controller/PhabricatorPeopleProfileEditController.php
View File

@@ -61,13 +61,8 @@ final class PhabricatorPeopleProfileEditController
$title = pht('Edit Profile');
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($user->getUsername())
->setHref($profile_uri));
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($title));
$crumbs->addTextCrumb($user->getUsername(), $profile_uri);
$crumbs->addTextCrumb($title);
$form = id(new AphrontFormView())
->setUser($viewer);

9
src/applications/people/controller/PhabricatorPeopleProfilePictureController.php
View File

@@ -91,13 +91,8 @@ final class PhabricatorPeopleProfilePictureController
$title = pht('Edit Profile Picture');
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($user->getUsername())
->setHref($profile_uri));
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($title));
$crumbs->addTextCrumb($user->getUsername(), $profile_uri);
$crumbs->addTextCrumb($title);
$form = id(new PHUIFormLayoutView())
->setUser($viewer);

5
src/applications/phame/controller/blog/PhameBlogEditController.php
View File

@@ -176,10 +176,7 @@ final class PhameBlogEditController
->setForm($form);
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($page_title)
->setHref($this->getApplicationURI('blog/new')));
$crumbs->addTextCrumb($page_title, $this->getApplicationURI('blog/new'));
$nav = $this->renderSideNavFilterView();
$nav->selectFilter($this->id ? null : 'blog/new');

5
src/applications/phame/controller/blog/PhameBlogListController.php
View File

@@ -48,10 +48,7 @@ final class PhameBlogListController extends PhameController {
$blog_list->setPager($pager);
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($title)
->setHref($this->getApplicationURI()));
$crumbs->addTextCrumb($title, $this->getApplicationURI());
$nav->appendChild(
array(

Some files were not shown because too many files have changed in this diff Show More