Set device to false for all pages which don't specify device readiness

Summary:
Ref T5446.

  - For all callsites which do not specify a value, set `false` explicitly.
  - Make `true` the default.

Test Plan: Used `grep`, then manually went through everything.

Reviewers: chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T5446

Differential Revision: https://secure.phabricator.com/D9687

src/applications/base/controller/PhabricatorController.php

@@ -293,7 +293,7 @@ abstract class PhabricatorController extends AphrontController {
       }
     }
 
-    if (idx($options, 'device')) {
+    if (idx($options, 'device', true)) {
       $page->setDeviceReady(true);
     }
 

src/applications/daemon/controller/PhabricatorDaemonCombinedLogController.php

@@ -38,6 +38,7 @@ final class PhabricatorDaemonCombinedLogController
       $nav,
       array(
         'title' => pht('Combined Daemon Log'),
+        'device' => false,
       ));
   }
 

src/applications/daemon/controller/PhabricatorDaemonConsoleController.php

@@ -226,6 +226,7 @@ final class PhabricatorDaemonConsoleController
       $nav,
       array(
         'title' => pht('Console'),
+        'device' => false,
       ));
   }
 

src/applications/daemon/controller/PhabricatorDaemonLogEventViewController.php

@@ -43,6 +43,7 @@ final class PhabricatorDaemonLogEventViewController
       ),
       array(
         'title' => pht('Combined Daemon Log'),
+        'device' => false,
       ));
   }
 

src/applications/daemon/controller/PhabricatorDaemonLogViewController.php

@@ -83,6 +83,7 @@ final class PhabricatorDaemonLogViewController
       ),
       array(
         'title' => pht('Daemon Log'),
+        'device' => false,
       ));
   }
 

src/applications/differential/controller/DifferentialChangesetViewController.php

@@ -281,6 +281,7 @@ final class DifferentialChangesetViewController extends DifferentialController {
       ),
       array(
         'title' => pht('Changeset View'),
+        'device' => false,
       ));
   }
 

src/applications/diffusion/controller/DiffusionBranchTableController.php

@@ -69,6 +69,7 @@ final class DiffusionBranchTableController extends DiffusionController {
           pht('Branches'),
           'r'.$repository->getCallsign(),
         ),
+        'device' => false,
       ));
   }
 

src/applications/diffusion/controller/DiffusionBrowseFileController.php

@@ -167,6 +167,7 @@ final class DiffusionBrowseFileController extends DiffusionBrowseController {
       ),
       array(
         'title' => $basename,
+        'device' => false,
       ));
   }
 

src/applications/diffusion/controller/DiffusionChangeController.php

@@ -96,6 +96,7 @@ final class DiffusionChangeController extends DiffusionController {
       ),
       array(
         'title' => pht('Change'),
+        'device' => false,
       ));
   }
 

src/applications/diffusion/controller/DiffusionCommitController.php

@@ -67,6 +67,7 @@ final class DiffusionCommitController extends DiffusionController {
         ),
         array(
           'title' => pht('Commit Still Parsing'),
+          'device' => false,
         ));
     }
 
@@ -400,6 +401,7 @@ final class DiffusionCommitController extends DiffusionController {
       array(
         'title' => $commit_id,
         'pageObjects' => array($commit->getPHID()),
+        'device' => false,
       ));
   }
 

src/applications/diffusion/controller/DiffusionLintController.php

@@ -172,6 +172,7 @@ final class DiffusionLintController extends DiffusionController {
       ),
       array(
         'title' => $title,
+        'device' => false,
       ));
   }
 

src/applications/diffusion/controller/DiffusionTagListController.php

@@ -90,6 +90,7 @@ final class DiffusionTagListController extends DiffusionController {
           pht('Tags'),
           $repository->getCallsign().' Repository',
         ),
+        'device' => false,
       ));
   }
 

src/applications/fact/controller/PhabricatorFactChartController.php

@@ -90,6 +90,7 @@ final class PhabricatorFactChartController extends PhabricatorFactController {
       ),
       array(
         'title' => 'Chart',
+        'device' => false,
       ));
   }
 

src/applications/fact/controller/PhabricatorFactHomeController.php

@@ -68,6 +68,7 @@ final class PhabricatorFactHomeController extends PhabricatorFactController {
       ),
       array(
         'title' => 'Facts',
+        'device' => false,
       ));
   }
 

src/applications/maniphest/controller/ManiphestBatchEditController.php

@@ -157,6 +157,7 @@ final class ManiphestBatchEditController extends ManiphestController {
       ),
       array(
         'title' => $title,
+        'device' => false,
       ));
   }
 

src/applications/maniphest/controller/ManiphestReportController.php

@@ -58,6 +58,7 @@ final class ManiphestReportController extends ManiphestController {
       $nav,
       array(
         'title' => pht('Maniphest Reports'),
+        'device' => false,
       ));
   }
 

src/applications/notification/controller/PhabricatorNotificationStatusController.php

@@ -30,6 +30,7 @@ final class PhabricatorNotificationStatusController
       ),
       array(
         'title' => pht('Notification Server Status'),
+        'device' => false,
       ));
   }
 

src/applications/search/controller/PhabricatorSearchHovercardController.php

@@ -56,6 +56,7 @@ final class PhabricatorSearchHovercardController
       return $this->buildApplicationPage(
         $cards,
         array(
+          'device' => false,
         ));
     } else {
       return id(new AphrontAjaxResponse())->setContent(

src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php

@@ -107,6 +107,7 @@ final class PhabricatorTypeaheadModularDatasourceController
       ),
       array(
         'title' => pht('Typeahead Results'),
+        'device' => false,
       ));
   }