archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Don't warn that workboard columns need a name when editing milestone columns

Browse Source 
Summary: See <https://discourse.phabricator-community.org/t/columns-must-have-a-name-while-editong-point-limit-on-milestone-column/2650>. This check doesn't make sense for proxy columns, including milestone columns.

Test Plan: Added a point limit to a milestone column.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20448
This commit is contained in:
epriestley
2019-04-18 05:30:07 -07:00
parent 23d8f000f7
commit cd2215fd4a
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/applications/project/xaction/column/PhabricatorProjectColumnNameTransaction.php
View File

@@ -41,7 +41,10 @@ final class PhabricatorProjectColumnNameTransaction
if ($this->isEmptyTextTransaction($object->getName(), $xactions)) { if ($this->isEmptyTextTransaction($object->getName(), $xactions)) {
// The default "Backlog" column is allowed to be unnamed, which // The default "Backlog" column is allowed to be unnamed, which
// means we use the default name. // means we use the default name.
if (!$object->isDefaultColumn()) {
// Proxy columns can't have a name, so don't raise an error here.
if (!$object->isDefaultColumn() && !$object->getProxy()) {
$errors[] = $this->newRequiredError( $errors[] = $this->newRequiredError(
pht('Columns must have a name.')); pht('Columns must have a name.'));
} }