Update Diff view page to new layout

Summary: Converts Diff View, single column though.

Test Plan: Upload a new diff, review page.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15470
This commit is contained in:
Chad Little
2016-03-13 16:01:05 -07:00
parent 301ecdef18
commit d76175285e

View File

@@ -126,27 +126,40 @@ final class DifferentialDiffViewController extends DifferentialController {
->setRenderingReferences($refs) ->setRenderingReferences($refs)
->setStandaloneURI('/differential/changeset/') ->setStandaloneURI('/differential/changeset/')
->setDiff($diff) ->setDiff($diff)
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setTitle(pht('Diff %d', $diff->getID())) ->setTitle(pht('Diff %d', $diff->getID()))
->setUser($request->getUser()); ->setUser($request->getUser());
$title = pht('Diff %d', $diff->getID());
$crumbs = $this->buildApplicationCrumbs(); $crumbs = $this->buildApplicationCrumbs();
$crumbs->addTextCrumb(pht('Diff %d', $diff->getID())); $crumbs->addTextCrumb($title);
$crumbs->setBorder(true);
$header = id(new PHUIHeaderView())
->setHeader($title);
$prop_box = id(new PHUIObjectBoxView()) $prop_box = id(new PHUIObjectBoxView())
->setHeader($property_head) ->setHeader($property_head)
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->addPropertyList($property_view) ->addPropertyList($property_view)
->setForm($form); ->setForm($form);
return $this->buildApplicationPage( $view = id(new PHUITwoColumnView())
array( ->setHeader($header)
$crumbs, ->setMainColumn(array(
))
->setFooter(array(
$prop_box, $prop_box,
$table_of_contents, $table_of_contents,
$details, $details,
),
array(
'title' => pht('Diff View'),
)); ));
$page = $this->newPage()
->setTitle(pht('Diff View'))
->setCrumbs($crumbs)
->appendChild($view);
return $page;
} }
private function loadSelectableRevisions( private function loadSelectableRevisions(