Use authoritative user identity for revision author
Summary: We added a proper way to get the authoritative user a while ago, this method just never got switched to use it. Test Plan: Created a revision locally, was recognized as the revision author. Reviewed By: jungejason Reviewers: gc3, jungejason, tuomaspelkonen, aran CC: aran, jungejason Differential Revision: 566
This commit is contained in:
@@ -26,7 +26,6 @@ class ConduitAPI_differential_createrevision_Method extends ConduitAPIMethod {
|
|||||||
return array(
|
return array(
|
||||||
'diffid' => 'required diffid',
|
'diffid' => 'required diffid',
|
||||||
'fields' => 'required dict',
|
'fields' => 'required dict',
|
||||||
'user' => 'required guid',
|
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -51,7 +50,7 @@ class ConduitAPI_differential_createrevision_Method extends ConduitAPIMethod {
|
|||||||
$revision = DifferentialRevisionEditor::newRevisionFromConduitWithDiff(
|
$revision = DifferentialRevisionEditor::newRevisionFromConduitWithDiff(
|
||||||
$fields,
|
$fields,
|
||||||
$diff,
|
$diff,
|
||||||
$request->getValue('user')); // TODO: Should be authoritative
|
$request->getUser()->getPHID());
|
||||||
|
|
||||||
return array(
|
return array(
|
||||||
'revisionid' => $revision->getID(),
|
'revisionid' => $revision->getID(),
|
||||||
|
|||||||
Reference in New Issue
Block a user