archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Don't display "Foul Magicks" in Maniphest

Browse Source 
Summary:
There was a typo:
`PHID-!!!!-NO_PROJECT` instead of
`PHID-!!!!-NO-PROJECT`

Also use `<em>` to differentiate from project named "(No Project)".

Test Plan:
/maniphest/report/project/
Click on (No Project).

Reviewers: epriestley

Reviewed By: epriestley

CC: aran

Differential Revision: https://secure.phabricator.com/D2167
This commit is contained in:
vrana
2012-04-09 01:07:12 -07:00
parent aa0d0396a6
commit db2fef4c87
2 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/applications/maniphest/controller/report/ManiphestReportController.php
View File

@@ -424,15 +424,15 @@ final class ManiphestReportController extends ManiphestController {
$leftover_closed = idx($result_closed, '', array()); $leftover_closed = idx($result_closed, '', array());
unset($result_closed['']); unset($result_closed['']);
$base_link = '/maniphest/?users=';
$leftover_name = phutil_render_tag( $leftover_name = phutil_render_tag(
'a', 'a',
array( array(
'href' => '/maniphest/?users=PHID-!!!!-UP-FOR-GRABS', 'href' => $base_link.ManiphestTaskOwner::OWNER_UP_FOR_GRABS,
), ),
'(Up For Grabs)'); '<em>(Up For Grabs)</em>');
$col_header = 'User'; $col_header = 'User';
$header = 'Open Tasks by User and Priority ('.$date.')'; $header = 'Open Tasks by User and Priority ('.$date.')';
$base_link = '/maniphest/?users=';
break; break;
case 'project': case 'project':
$result = array(); $result = array();
@@ -461,15 +461,15 @@ final class ManiphestReportController extends ManiphestController {
} }
} }
$base_link = '/maniphest/view/all/?projects=';
$leftover_name = phutil_render_tag( $leftover_name = phutil_render_tag(
'a', 'a',
array( array(
'href' => '/maniphest/view/all/?projects=PHID-!!!!-NO_PROJECT', 'href' => $base_link.ManiphestTaskOwner::PROJECT_NO_PROJECT,
), ),
'(No Project)'); '<em>(No Project)</em>');
$col_header = 'Project'; $col_header = 'Project';
$header = 'Open Tasks by Project and Priority ('.$date.')'; $header = 'Open Tasks by Project and Priority ('.$date.')';
$base_link = '/maniphest/view/all/?projects=';
break; break;
} }

1
src/applications/maniphest/controller/report/__init__.php
View File

@@ -8,6 +8,7 @@
phutil_require_module('phabricator', 'aphront/response/404'); phutil_require_module('phabricator', 'aphront/response/404');
phutil_require_module('phabricator', 'aphront/response/redirect'); phutil_require_module('phabricator', 'aphront/response/redirect');
phutil_require_module('phabricator', 'applications/maniphest/constants/owner');
phutil_require_module('phabricator', 'applications/maniphest/constants/priority'); phutil_require_module('phabricator', 'applications/maniphest/constants/priority');
phutil_require_module('phabricator', 'applications/maniphest/constants/status'); phutil_require_module('phabricator', 'applications/maniphest/constants/status');
phutil_require_module('phabricator', 'applications/maniphest/constants/transactiontype'); phutil_require_module('phabricator', 'applications/maniphest/constants/transactiontype');