Change (No Filtering) to be the default selected option.

Summary: Cleaning up my mess, (No Filtering) should be the default selected option in macros search form.

Test Plan: Go to /macro/query/advanced/ and verify that (No Filtering) is the default selected option.

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, aran

Maniphest Tasks: T3692

Differential Revision: https://secure.phabricator.com/D6715

src/applications/macro/query/PhabricatorMacroSearchEngine.php

@@ -14,7 +14,7 @@ final class PhabricatorMacroSearchEngine
     $saved->setParameter('nameLike', $request->getStr('nameLike'));
     $saved->setParameter('createdStart', $request->getStr('createdStart'));
     $saved->setParameter('createdEnd', $request->getStr('createdEnd'));
-    $saved->setParameter('flagColor', $request->getStr('flagColor'));
+    $saved->setParameter('flagColor', $request->getStr('flagColor', '-1'));
 
     return $saved;
   }