Update Facts for newPage
Summary: No UI updates, just swapping over to `newPage` Test Plan: Pull up each page. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, yelirekim Differential Revision: https://secure.phabricator.com/D15601
This commit is contained in:
@@ -77,14 +77,13 @@ final class PhabricatorFactChartController extends PhabricatorFactController {
|
||||
$crumbs = $this->buildApplicationCrumbs();
|
||||
$crumbs->addTextCrumb(pht('Chart'));
|
||||
|
||||
return $this->buildApplicationPage(
|
||||
array(
|
||||
$crumbs,
|
||||
$box,
|
||||
),
|
||||
array(
|
||||
'title' => pht('Chart'),
|
||||
));
|
||||
$title = pht('Chart');
|
||||
|
||||
return $this->newPage()
|
||||
->setTitle($title)
|
||||
->setCrumbs($crumbs)
|
||||
->appendChild($box);
|
||||
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
@@ -59,15 +59,16 @@ final class PhabricatorFactHomeController extends PhabricatorFactController {
|
||||
$crumbs = $this->buildApplicationCrumbs();
|
||||
$crumbs->addTextCrumb(pht('Home'));
|
||||
|
||||
return $this->buildApplicationPage(
|
||||
array(
|
||||
$crumbs,
|
||||
$title = pht('Facts');
|
||||
|
||||
return $this->newPage()
|
||||
->setTitle($title)
|
||||
->setCrumbs($crumbs)
|
||||
->appendChild(array(
|
||||
$chart_form,
|
||||
$panel,
|
||||
),
|
||||
array(
|
||||
'title' => pht('Facts'),
|
||||
));
|
||||
|
||||
}
|
||||
|
||||
private function buildChartForm() {
|
||||
|
||||
Reference in New Issue
Block a user