archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix various lint issues in rJX

Browse Source 
Summary: Ref T6953.

Test Plan: `arc lint`

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T6953

Differential Revision: https://secure.phabricator.com/D11376
This commit is contained in:
Joshua Spence
2015-01-14 07:59:56 +11:00
parent d0e4e96041
commit e768a633b7
20 changed files with 39 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
webroot/rsrc/externals/javelin/core/__tests__/stratcom.js vendored
View File

@@ -3,10 +3,10 @@
* javelin-dom
*/
describe('Stratcom Tests', function() {
node1 = document.createElement('div');
var node1 = document.createElement('div');
JX.Stratcom.addSigil(node1, 'what');
node2 = document;
node3 = document.createElement('div');
var node2 = document;
var node3 = document.createElement('div');
node3.className = 'what';
it('should disallow document', function() {

2
webroot/rsrc/externals/javelin/core/__tests__/util.js vendored
View File

@@ -29,7 +29,7 @@ describe('JX.isArray', function() {
it('should identify an array from another context as an array', function() {
var iframe = document.createElement('iframe');
var name = iframe.name = 'javelin-iframe-test';
iframe.name = 'javelin-iframe-test';
iframe.style.display = 'none';
document.body.insertBefore(iframe, document.body.firstChild);

2
webroot/rsrc/externals/javelin/core/install.js vendored
View File

@@ -236,7 +236,7 @@ JX.createClass = function(junk) {
};
};
var getter = function(prop) {
return function(v) {
return function() {
return this[prop];
};
};

2
webroot/rsrc/externals/javelin/core/util.js vendored
View File

@@ -283,7 +283,7 @@ if (!window.console || !window.console.log) {
if (window.opera && window.opera.postError) {
window.console = {log: function(m) { window.opera.postError(m); }};
} else {
window.console = {log: function(m) { }};
window.console = {log: function() {}};
}
}

2
webroot/rsrc/externals/javelin/ext/reactor/core/Reactor.js vendored
View File

@@ -38,7 +38,7 @@ JX.install('Reactor', {
* For internal use by the Reactor system.
*/
_postOrder : function(node, result, pending) {
if (typeof result === "undefined") {
if (typeof result === 'undefined') {
result = [];
pending = {};
}

2
webroot/rsrc/externals/javelin/ext/reactor/core/ReactorNode.js vendored
View File

@@ -57,7 +57,7 @@ JX.install('ReactorNode', {
/**
* For internal use by the Reactor system
*/
getNextPulse : function(pulse) {
getNextPulse : function() {
return this._nextPulse;
},
getTransformer : function() {

6
webroot/rsrc/externals/javelin/ext/reactor/dom/RDOM.js vendored
View File

@@ -121,7 +121,7 @@ JX.install('RDOM', {
if (__DEV__) {
if (!found) {
throw new Error("Mismatched radio button value");
throw new Error('Mismatched radio button value');
}
}
});
@@ -163,7 +163,7 @@ JX.install('RDOM', {
return rnode.transform(function(val) {
if (__DEV__) {
if (!(val === true || val === false)) {
throw new Error("Send boolean values to checkboxes.");
throw new Error('Send boolean values to checkboxes.');
}
}
@@ -255,7 +255,7 @@ JX.install('RDOM', {
if (__DEV__) {
if (select.value !== val) {
throw new Error("Mismatched select value");
throw new Error('Mismatched select value');
}
}
});

16
webroot/rsrc/externals/javelin/ext/view/HTMLView.js vendored
View File

@@ -26,10 +26,10 @@ JX.install('HTMLView', {
return new JX.ViewVisitor(JX.HTMLView.validate);
},
validate: function(view, children) {
validate: function(view) {
var spec = this._getHTMLSpec();
if (!(view.getName() in spec)) {
throw new Error("invalid tag");
throw new Error('invalid tag');
}
var tag_spec = spec[view.getName()];
@@ -37,11 +37,11 @@ JX.install('HTMLView', {
var attrs = view.getAllAttributes();
for (var attr in attrs) {
if (!(attr in tag_spec)) {
throw new Error("invalid attr");
throw new Error('invalid attr');
}
var validator = tag_spec[attr];
if (typeof validator === "function") {
if (typeof validator === 'function') {
return validator(attrs[attr]);
}
}
@@ -51,10 +51,10 @@ JX.install('HTMLView', {
_validateRel: function(target) {
return target in {
"_blank": 1,
"_self": 1,
"_parent": 1,
"_top": 1
'_blank': 1,
'_self': 1,
'_parent': 1,
'_top': 1
};
},
_getHTMLSpec: function() {

2
webroot/rsrc/externals/javelin/ext/view/ViewInterpreter.js vendored
View File

@@ -56,7 +56,7 @@ JX.install('ViewInterpreter', {
if (properties instanceof JX.View ||
properties instanceof JX.HTML ||
properties.nodeType ||
typeof properties === "string") {
typeof properties === 'string') {
children.unshift(properties);
properties = {};
}

4
webroot/rsrc/externals/javelin/ext/view/ViewPlaceholder.js vendored
View File

@@ -53,12 +53,12 @@
JX.behavior('view-placeholder', function(config, statics) {
JX.behavior('view-placeholder', function(config) {
JX.ViewPlaceholder.register(config.trigger_id, config.id, function() {
var replace = JX.$(config.id);
var children = config.children;
if (typeof children === "string") {
if (typeof children === 'string') {
children = JX.$H(children);
}

4
webroot/rsrc/externals/javelin/ext/view/__tests__/ViewRenderer.js vendored
View File

@@ -11,11 +11,11 @@ describe('JX.ViewRenderer', function() {
var child = new JX.View({});
var parent = new JX.View({});
parent.addChild(child);
child.render = function(_) {
child.render = function() {
child_rendered = true;
};
parent.render = function(rendered_children) {
parent.render = function() {
child_rendered_first = child_rendered;
};

3
webroot/rsrc/externals/javelin/lib/Leader.js vendored
View File

@@ -219,7 +219,7 @@ JX.install('Leader', {
_read: function() {
var self = JX.Leader;
leader = window.localStorage.getItem(self._leaderKey) || '0:0';
var leader = window.localStorage.getItem(self._leaderKey) || '0:0';
leader = leader.split(':');
return {
@@ -305,4 +305,3 @@ JX.install('Leader', {
}
});

8
webroot/rsrc/externals/javelin/lib/Request.js vendored
View File

@@ -39,10 +39,10 @@ JX.install('Request', {
try {
return new XMLHttpRequest();
} catch (x) {
return new ActiveXObject("Msxml2.XMLHTTP");
return new ActiveXObject('Msxml2.XMLHTTP');
}
} catch (x) {
return new ActiveXObject("Microsoft.XMLHTTP");
return new ActiveXObject('Microsoft.XMLHTTP');
}
},
@@ -269,10 +269,10 @@ JX.install('Request', {
try {
if (typeof DOMParser != 'undefined') {
var parser = new DOMParser();
doc = parser.parseFromString(text, "text/xml");
doc = parser.parseFromString(text, 'text/xml');
} else { // IE
// an XDomainRequest
doc = new ActiveXObject("Microsoft.XMLDOM");
doc = new ActiveXObject('Microsoft.XMLDOM');
doc.async = false;
doc.loadXML(xport.responseText);
}

2
webroot/rsrc/externals/javelin/lib/Resource.js vendored
View File

@@ -25,7 +25,7 @@ JX.install('Resource', {
*/
load: function(list, callback) {
var resources = {},
uri, resource, path, type;
uri, resource, path;
list = JX.$AX(list);

4
webroot/rsrc/externals/javelin/lib/WebSocket.js vendored
View File

@@ -107,7 +107,7 @@ JX.install('WebSocket', {
/**
* Callback for connection open.
*/
_onopen: function(e) {
_onopen: function() {
this._isOpen = true;
// Reset the reconnect delay, since we connected successfully.
@@ -144,7 +144,7 @@ JX.install('WebSocket', {
/**
* Callback for connection close.
*/
_onclose: function(e) {
_onclose: function() {
this._isOpen = false;
var done = false;

2
webroot/rsrc/externals/javelin/lib/__tests__/JSON.js vendored
View File

@@ -7,7 +7,7 @@ describe('JSON', function() {
it('should encode and decode an object', function() {
var object = {
a: [0, 1, 2],
s: "Javelin Stuffs",
s: 'Javelin Stuffs',
u: '\x01',
n: 1,
f: 3.14,

2
webroot/rsrc/externals/javelin/lib/__tests__/URI.js vendored
View File

@@ -43,7 +43,7 @@ describe('Javelin URI', function() {
});
function charRange(from, to) {
res = '';
var res = '';
for (var i = from.charCodeAt(0); i <= to.charCodeAt(0); i++) {
res += String.fromCharCode(i);
}

4
webroot/rsrc/externals/javelin/lib/control/tokenizer/Tokenizer.js vendored
View File

@@ -250,7 +250,6 @@ JX.install('Tokenizer', {
}
this._lastvalue = focus.value;
var root = this._root;
var metrics = JX.DOM.textMetrics(
this._focus,
'jx-tokenizer-metrics');
@@ -353,9 +352,6 @@ JX.install('Tokenizer', {
},
_onkeydown : function(e) {
var focus = this._focus;
var root = this._root;
var raw = e.getRawEvent();
if (raw.ctrlKey || raw.metaKey || raw.altKey) {
return;

8
webroot/rsrc/externals/javelin/lib/control/typeahead/Typeahead.js vendored
View File

@@ -137,9 +137,9 @@ JX.install('Typeahead', {
if (__DEV__) {
if (!this._datasource) {
throw new Error(
"JX.Typeahead.start(): " +
"No datasource configured. Create a datasource and call " +
"setDatasource().");
'JX.Typeahead.start(): ' +
'No datasource configured. Create a datasource and call ' +
'setDatasource().');
}
}
this.updatePlaceholder();
@@ -402,7 +402,7 @@ JX.install('Typeahead', {
this._choose(this._display[this._focus]);
return true;
} else {
result = this.invoke('query', this._control.value);
var result = this.invoke('query', this._control.value);
if (result.getPrevented()) {
return true;
}

2
webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadSource.js vendored
View File

@@ -147,7 +147,7 @@ JX.install('TypeaheadSource', {
this._startListener.remove();
},
didChange : function(value) {
didChange : function() {
return;
},