archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

When requiring login signatures, order documents from oldest to newest

Browse Source 
Summary: Depends on D18788. Ref T13024. Currently, we prompt users to sign from newest to oldest. This seems less intuitive than oldest to newest.

Test Plan: Dumped document order, saw it swap to oldest-first.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13024

Differential Revision: https://secure.phabricator.com/D18789
This commit is contained in:
epriestley
2017-11-27 16:54:26 -08:00
parent ba4b9f7184
commit e850bc6b95
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/applications/base/controller/PhabricatorController.php
View File

@@ -560,6 +560,7 @@ abstract class PhabricatorController extends AphrontController {
->setViewer($viewer) ->setViewer($viewer)
->withSignatureRequired(1) ->withSignatureRequired(1)
->needViewerSignatures(true) ->needViewerSignatures(true)
->setOrder('oldest')
->execute(); ->execute();
$must_sign_docs = array(); $must_sign_docs = array();