Fix accidental forward dependency in old commit summary migration
Summary: See IRC. This migration inadvertently depends on the columns in the commit table, because it calls `save()`, and thus broke for installs with data after we added the `importStatus` column. Since that was ~9 months after this patch, probably not many installs are affected. Test Plan: Ran patch locally with `--apply` on data. Had user verify fix. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D8152
This commit is contained in:
@@ -2,7 +2,9 @@
|
||||
|
||||
echo "Backfilling commit summaries...\n";
|
||||
|
||||
$commits = new LiskMigrationIterator(new PhabricatorRepositoryCommit());
|
||||
$table = new PhabricatorRepositoryCommit();
|
||||
$conn_w = $table->establishConnection('w');
|
||||
$commits = new LiskMigrationIterator($table);
|
||||
foreach ($commits as $commit) {
|
||||
echo 'Filling Commit #'.$commit->getID()."\n";
|
||||
|
||||
@@ -18,8 +20,12 @@ foreach ($commits as $commit) {
|
||||
continue;
|
||||
}
|
||||
|
||||
$commit->setSummary($data->getSummary());
|
||||
$commit->save();
|
||||
queryfx(
|
||||
$conn_w,
|
||||
'UPDATE %T SET summary = %s WHERE id = %d',
|
||||
$commit->getTableName(),
|
||||
$data->getSummary(),
|
||||
$commit->getID());
|
||||
}
|
||||
|
||||
echo "Done.\n";
|
||||
|
||||
Reference in New Issue
Block a user