02c3200867
Summary: Fixes T5534. If you `git push origin :refs/tags/doesnotexist` (for some non-existing tag), we get a change where both the old and new refs are empty. We incorrectly call this an "add", because the old ref is empty. Instead, call this a "delete", but skip the logic which would normally mark it dangerous. (Possibly we should just reject these outright, but Git allows them, so stick with that for now.) Test Plan: Pushed nonexistent refs: ``` $ git push origin :refs/tags/doesnotexist remote: warning: Allowing deletion of corrupt ref. To ssh://dweller@localhost/diffusion/POEMS/ - [deleted] doesnotexist $ ``` Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T5534 Differential Revision: https://secure.phabricator.com/D9800
Phabricator is an open source collection of web applications which help software companies build better software. Phabricator includes applications for: - reviewing and auditing source code; - hosting and browsing repositories; - assembling a party to venture forth; - tracking bugs; - hiding stuff from coworkers; and - also some other things. You can learn more about the project (and find links to documentation and resources) here: http://phabricator.org/ Phabricator is developed and maintained by Phacility. The first version of Phabricator was originally built at Facebook. LICENSE Phabricator is released under the Apache 2.0 license except as otherwise noted.