03fb1887d3
Summary: The CSRF changes meant that we can't generate a file URI with just its PHID anymore, and converted a mathematical function into a service call. Unfortunately, this caused massive perf problems in some parts of the application, critically handles, where loading N users became N single gets. Derp derp derp. Remedy this by doing a single multiget. This substantially improves performance of many interfaces, particularly the Maniphest task list. I need to go through the rest of the PhabricatorFileURI callsites and get rid of them, but I think this is the most substantive one. Test Plan: Profiled Maniphest task list, queries went from >100 to a handful. Explosion of multiderp. :/ Looked at some views with profile photos to verify they still render accurately. Reviewers: jungejason, nh, tuomaspelkonen, aran Reviewed By: aran CC: aran Differential Revision: 921
Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. Phabricator was developed at Facebook. This is an early release. It's pretty high-quality and usable, but under active development so things may change quickly. You can learn more about the project and find links to documentation and resources at: http://phabricator.org/ LICENSE Phabricator is released under the Apache 2.0 license except as otherwise noted. http://www.apache.org/licenses/LICENSE-2.0