1f86c73428
Summary: Ref T603. Moves to detangle and optimize how we apply policies to filtering objects. Notably: - Add a short circuit for omnipotent users. - When performing project filtering, do a stricter check for user membership. We don't actually care if the user can see the project or not according to other policy constraints, and checking if they can may be complicated. - When performing project filtering, do a local check to see if we're filtering the project itself. This is a common case (a project editable by members of itself, for example) and we can skip queries when it is satisfied. - Don't perform policy filtering in ObjectQuery. All the data it aggregates is already filtered correctly. - Clean up a little bit of stuff in Feed. Test Plan: Pages like the Maniphest task list and Project profile pages now issue dramatically fewer queries. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D6931
Phabricator is an open source collection of web applications which make it easier to write, review, and share source code. Phabricator was developed at Facebook. It's pretty high-quality and usable, but under active development so things may change quickly. You can learn more about the project and find links to documentation and resources at: http://phabricator.org/ LICENSE Phabricator is released under the Apache 2.0 license except as otherwise noted.