epriestley
204d1de683
Summary: Depends on D18926. Ref T6203. Ref T13048. Herald rule repetition policies are stored as integers but treated as strings in most contexts. After D18926, the integer stuff is almost totally hidden inside `HeraldRule` and getting rid of it completely isn't too tricky. Do so now. Test Plan: - Created "only the first time" and "every time" rules. Did a SELECT on their rows in the database. - Ran migrations, got a clean bill of health from `storage adjust`. - Did another SELECT on the rows, saw a faithful conversion to strings "every" and "first". - Edited and reviewed rules, swapping them between "every" and "first". Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13048, T6203 Differential Revision: https://secure.phabricator.com/D18927
Phabricator is a collection of web applications which help software companies build better software.
Phabricator includes applications for:
- reviewing and auditing source code;
- hosting and browsing repositories;
- tracking bugs;
- managing projects;
- conversing with team members;
- assembling a party to venture forth;
- writing stuff down and reading it later;
- hiding stuff from coworkers; and
- also some other things.
You can learn more about the project (and find links to documentation and resources) at Phabricator.org
Phabricator is developed and maintained by Phacility.
SUPPORT RESOURCES
For resources on filing bugs, requesting features, reporting security issues, and getting other kinds of support, see Support Resources.
NO PULL REQUESTS!
We do not accept pull requests through GitHub. If you would like to contribute code, please read our Contributor's Guide.
LICENSE
Phabricator is released under the Apache 2.0 license except as otherwise noted.