241cfc2e83
Summary: Ref T4284. This fixes at least one problem which can cause the observed behavior. Test Plan: - Before applying patch, used `PHABRICATOR_CREDENTIAL=PHID-CDTL-... bin/ssh-connect` + debugging prints to verify the keyfile was written and cleaned up normally. - Destroyed the credental, verified the temporary file was not cleand up correctly. - Applied patch, verified temporary file was not written and command exited with sensible error. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4284 Differential Revision: https://secure.phabricator.com/D10328
Phabricator is an open source collection of web applications which help software companies build better software. Phabricator includes applications for: - reviewing and auditing source code; - hosting and browsing repositories; - assembling a party to venture forth; - tracking bugs; - hiding stuff from coworkers; and - also some other things. You can learn more about the project (and find links to documentation and resources) [[http://phabricator.org/ | here]]. Phabricator is developed and maintained by [[http://phacility.com/ | Phacility]]. The first version of Phabricator was originally built at Facebook. = LICENSE = Phabricator is released under the Apache 2.0 license except as otherwise noted.