3aed39b8b0
Fixes T10981. Ref T10939. `arc` currently has some odd, hard-coded checks (missing reviewers, all reviewers away) that depend on the field value being in a certain format. The recent changes swapped the field value from scalars (PHIDs) to dictionaries and broke this workflow. It worked fine in testing because we apply these checks very inconsistently (not on update or `--edit`). To get around this for now, serialize into "PHID!" and then unserialize on the other side. This is icky but keeps us from needing to require an `arc` upgrade. These checks are generally bad news and should move to the server side in the long run (T4631). (This probably prevents clean `arc diff`, so I'm just cowboy committing it.) Auditors: chad
Phabricator is a collection of web applications which help software companies build better software.
Phabricator includes applications for:
- reviewing and auditing source code;
- hosting and browsing repositories;
- tracking bugs;
- managing projects;
- conversing with team members;
- assembling a party to venture forth;
- writing stuff down and reading it later;
- hiding stuff from coworkers; and
- also some other things.
You can learn more about the project (and find links to documentation and resources) at Phabricator.org
Phabricator is developed and maintained by Phacility.
SUPPORT RESOURCES
For resources on filing bugs, requesting features, reporting security issues, and getting other kinds of support, see Support Resources.
NO PULL REQUESTS!
We do not accept pull requests through GitHub. If you would like to contribute code, please read our Contributor's Guide.
LICENSE
Phabricator is released under the Apache 2.0 license except as otherwise noted.