4dfdd0d316
Summary: Ref T3903. Ref T603. We currently overreact to invalid policies. Instead: - For non-omnipotent users, just reject the viewer. - For omnipotent users, we already shortcircuit and permit the viewer. - Formalize and add test coverage for these behaviors. Also clean up some strings. The practical effect of this is that setting an object to an invalid policy (either intentionally or accidentally) doesn't break callers who are querying it. Test Plan: - Created a Legalpad document and set view policy to "asldkfnaslkdfna". - Verified this policy behaved as though it were "no one". - Added, executed unit tests. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T603, T3903 Differential Revision: https://secure.phabricator.com/D7185
Phabricator is an open source collection of web applications which make it easier to write, review, and share source code. Phabricator was developed at Facebook. It's pretty high-quality and usable, but under active development so things may change quickly. You can learn more about the project and find links to documentation and resources at: http://phabricator.org/ LICENSE Phabricator is released under the Apache 2.0 license except as otherwise noted.