9ab1b5a22d
Summary: Ref T2450. This reorganizes code to improve performance. Mostly, there are a lot of things which are unique per commit (author name, links, short name, etc), but we were rendering them for every line. This often meant we'd render the same author's name thousands of times. This is slower than rendering it only once. In 99% of interfaces this doesn't matter, but blame is weird and it's significant on big files. Test Plan: Locally, `__phutil_library_map__.php` now has costs of roughly: - 550ms for main content (from 650ms before the patch). - 1,500ms for blame content (frrom 1,800ms before the patch). So this isn't huge, is a decent ~20%-ish performance gain for shuffling some stuff around. Reviewers: chad Reviewed By: chad Maniphest Tasks: T2450 Differential Revision: https://secure.phabricator.com/D14963
Phabricator is a collection of web applications which help software companies build better software.
Phabricator includes applications for:
- reviewing and auditing source code;
- hosting and browsing repositories;
- tracking bugs;
- managing projects;
- conversing with team members;
- assembling a party to venture forth;
- writing stuff down and reading it later;
- hiding stuff from coworkers; and
- also some other things.
You can learn more about the project (and find links to documentation and resources) at Phabricator.org
Phabricator is developed and maintained by Phacility.
SUPPORT RESOURCES
For resources on filing bugs, requesting features, reporting security issues, and getting other kinds of support, see Support Resources.
NO PULL REQUESTS!
We do not accept pull requests through GitHub. If you would like to contribute code, please read our Contributor's Guide.
LICENSE
Phabricator is released under the Apache 2.0 license except as otherwise noted.