9f8907ccf7
Summary: Fixes T12789. See that task for discussion. Currently, when multiple packages own the same path but have different dominion rules we get some weird/aribtrary/inconsistent results. Instead, implement these rules: - If zero or more weak and one or more strong packages claim a path, the strong packages (exactly) all own it. - If one or more weak packages and zero strong packages claim a path, the weak packages all own it. The major change here is that instead of keeping the //first// weak package we run into, we keep all the weak packages with the longest claim that we run into. This needs to be implemented twice because Owners has two different near-copies of this logic, only one of which has test coverage. Some day maybe this will get fixed. Test Plan: - Added failing unit tests, made them pass. - Viewed all A/B strong/weak combinations in Diffusion, saw sensible ownership results. Reviewers: chad, lvital Reviewed By: lvital Subscribers: lvital Maniphest Tasks: T12789 Differential Revision: https://secure.phabricator.com/D18064
Phabricator is a collection of web applications which help software companies build better software.
Phabricator includes applications for:
- reviewing and auditing source code;
- hosting and browsing repositories;
- tracking bugs;
- managing projects;
- conversing with team members;
- assembling a party to venture forth;
- writing stuff down and reading it later;
- hiding stuff from coworkers; and
- also some other things.
You can learn more about the project (and find links to documentation and resources) at Phabricator.org
Phabricator is developed and maintained by Phacility.
SUPPORT RESOURCES
For resources on filing bugs, requesting features, reporting security issues, and getting other kinds of support, see Support Resources.
NO PULL REQUESTS!
We do not accept pull requests through GitHub. If you would like to contribute code, please read our Contributor's Guide.
LICENSE
Phabricator is released under the Apache 2.0 license except as otherwise noted.