epriestley
c86dfd84d9
Summary: This doesn't cover every case exhaustively (see comments) but should cover like 98% of the practical cases. This makes one workflow modification: willWriteRevision() was previously guaranteed to have a revisionID / revisionPHID and no longer is. I verified that no field implementations depend on this behavior. Fields which depend on IDs should be using didWriteRevision() instead. Test Plan: Inserted a "throw" into the middle of the transactions and created revisions; they didn't orphan. Created revisions normally, they worked correctly. Reviewers: btrahan, nh Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T605 Differential Revision: https://secure.phabricator.com/D1541
Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. Phabricator was developed at Facebook. This is an early release. It's pretty high-quality and usable, but under active development so things may change quickly. You can learn more about the project and find links to documentation and resources at: http://phabricator.org/ LICENSE Phabricator is released under the Apache 2.0 license except as otherwise noted. http://www.apache.org/licenses/LICENSE-2.0