d031d3ae32
Summary: See comments. I think this will fix the issue, where we end up handling off garbage to htmlspecialchars() after highlighting a file we've stuck full of \0 bytes. The right fix for this is to make wordwrap and intraline-diff utf8 aware and throw this whole thing away. I'll work on that but I think this fixes the immediate issue. Test Plan: diffed the file with a UTF-8 quote in it and got a reasonable render in Differential Reviewed By: jungejason Reviewers: jungejason, aran, tuomaspelkonen CC: aran, jungejason Differential Revision: 504
PROJECT STATUS: CAVEAT EMPTOR This is an unstable preview release. You can learn more at http://phabricator.org/ as well as click around our development install. Developer mailing list at https://groups.google.com/group/phabricator-dev and please report issues using GitHub. WHAT IS PHABRICATOR? Phabricator is a suite of web applications that facilitate software development tasks, particularly code review. The primary application in the suite is Differential, a code review tool. Phabricator is highly unstable and has many missing features! These applications are being brought over from Facebook's internal toolset, but there's a lot of stuff that hasn't made it over yet. Feel free to follow the project but you probably shouldn't try to install this yet unless you're extremely ambitious or just want to take a look at it. LICENSE Phabricator is released under the Apache 2.0 license except as otherwise noted. http://www.apache.org/licenses/LICENSE-2.0