epriestley da60c71fb8 Fix ApplicationTransaction "no effect" error for mentions of already-mentioned users
Summary:
Fixes T3139. See that task for discussion.

If all mentions are removed because they're already subscribed, we currently generate an empty transaction, which later gets picked up as having no effect and the user gets yelled at.

Instead, don't generate a transaction if no PHIDs remain after filtering already-subscribed PHIDs.

Test Plan: Followed plan in T3139.

Reviewers: garoevans, btrahan

Reviewed By: garoevans

CC: aran

Maniphest Tasks: T3139

Differential Revision: https://secure.phabricator.com/D6048
2013-05-26 14:15:29 -07:00
2013-04-28 13:22:33 -07:00
2012-11-03 22:34:44 -07:00
2013-04-03 12:58:39 -07:00
2012-11-05 11:16:51 -08:00
2013-01-03 05:45:08 -08:00

Phabricator is an open source collection of web applications which make it
easier to write, review, and share source code. Phabricator was developed at
Facebook.

This is an early release. It's pretty high-quality and usable, but under
active development so things may change quickly.

You can learn more about the project and find links to documentation and
resources at: http://phabricator.org/

LICENSE

Phabricator is released under the Apache 2.0 license except as otherwise noted.
Description
Phabricator
Readme 105 MiB
Languages
PHP 93.4%
JavaScript 4.1%
CSS 2.4%