e6118bcbaf
Summary: Fixes T4362. If you have a default edit + view policy of "no one" things get weird when you try to create a task - basically its impossible. Ergo, re-jigger how we do policy checks just a bit. - if its a new object, don't bother with the "can the $actor edit this thing by virtue of having can see / can edit priveleges?" That makes no sense on create. - add a hook so when doing the "will $actor still be able to edit this thing after all the edits" checks the object can be updated to its ultimate state. This matters for Maniphest as being the owner lets you do all sorts of stuff. Test Plan: - made a task with no one policy and assigned to no one - exception - made a task with no one policy and assigned to me - success - made a comment on the task - success - reassigned the task to another user - exception - reassigned the task to another user and updated policies to "users" - success Reviewers: epriestley Reviewed By: epriestley Subscribers: aran, epriestley, Korvin Maniphest Tasks: T4362 Differential Revision: https://secure.phabricator.com/D8508
Phabricator is an open source collection of web applications which help software companies build better software. Phabricator includes applications for: - reviewing and auditing source code; - hosting and browsing repositories; - assembling a party to venture forth; - tracking bugs; - hiding stuff from coworkers; and - also some other things. You can learn more about the project (and find links to documentation and resources) here: http://phabricator.org/ Phabricator is developed and maintained by Phacility. The first version of Phabricator was originally built at Facebook. LICENSE Phabricator is released under the Apache 2.0 license except as otherwise noted.