David Fisher
e846a1747e
Summary: The feed time is stored as the upper 32 bits of PhabricatorFeedStoryData::chronologicalKey. These bits were previously accessed by right shifting, which does not work properly on 32 bit machines (the result is PHP_INT_MAX). We now attempt to use the bc extension (if available) and fall back on mysql math otherwise. (See T500, D912). Test Plan: The calculation is unchanged for 64 bit machines. I checked both paths on a 32 bit machine with bc extension available by setting the appropriate if-condition to false and true. Reviewers: epriestley Reviewed By: epriestley CC: ddfisher, aran, epriestley Differential Revision: https://secure.phabricator.com/D1726
Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. Phabricator was developed at Facebook. This is an early release. It's pretty high-quality and usable, but under active development so things may change quickly. You can learn more about the project and find links to documentation and resources at: http://phabricator.org/ LICENSE Phabricator is released under the Apache 2.0 license except as otherwise noted. http://www.apache.org/licenses/LICENSE-2.0