epriestley
eb397a48b4
Summary: Fixes T4356. Currently, if users add a passworded private key to the Passphrase application, we never ask for the password and can not use it later. This makes several changes: - Prompt for the password. - Detect passworded private keys, and don't accept them until we can decrypt them. - Try to decrypt passworded private keys, and tell the user if the password is missing or incorrect. - Stop further creation of path-based private keys, which are really just for compatibility. We can't do anything reasonable about passwords with these, since users can change the files. Test Plan: Created a private key with a password, was prompted to provide it, tried empty/bad passwords, provided the correct password and had the key decrypted for use. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T4356 Differential Revision: https://secure.phabricator.com/D8102
Phabricator is an open source collection of web applications which help software companies build better software. Phabricator includes applications for: - reviewing and auditing source code; - hosting and browsing repositories; - assembling a party to venture forth; - tracking bugs; - hiding stuff from coworkers; and - also some other things. You can learn more about the project (and find links to documentation and resources) here: http://phabricator.org/ Phabricator is developed and maintained by Phacility. The first version of Phabricator was originally built at Facebook. LICENSE Phabricator is released under the Apache 2.0 license except as otherwise noted.