fe6022cd97
Summary: Fixes a TODO, and silences a warning introduced by D3601. There are several cases where we load data like: SELECT *, ... AS extraData FROM ... ...and then pass it to `loadAllFromArray()`. Currently, this causes us to set an `extraData` property on the object. This idiom seems fairly useful and non-dangerous, so I made `loadFromArray()` just drop extra keys. Since we hit this loop a potentially huge number of times (10,000+ for full Maniphest pages) I did some microoptimization. Lisk is hot enough that it's one of the few places where it's worthwhile (see D1291). Test Plan: Loaded homepage, no longer got warnings about `viewerIsMember` from Project queries. Browsed ~10 apps, didn't see any issues. Reviewers: vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D3606
Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. Phabricator was developed at Facebook. This is an early release. It's pretty high-quality and usable, but under active development so things may change quickly. You can learn more about the project and find links to documentation and resources at: http://phabricator.org/ LICENSE Phabricator is released under the Apache 2.0 license except as otherwise noted. http://www.apache.org/licenses/LICENSE-2.0