archive/pillar
0
0
Fork 0
Code Issues 42 Pull Requests Projects Releases Wiki Activity

Added TODOs and removed fetching unused field from MongoDB

Browse Source
This commit is contained in:
Sybren A. Stüvel 2018-10-03 14:20:29 +02:00
parent 53811363ce
commit 7e941e2299
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pillar/badge_sync.py
View File

@ -33,7 +33,7 @@ def find_users_to_sync() -> typing.Iterable[SyncUser]:
{'$match': { {'$match': {
'token': {'$exists': True}, 'token': {'$exists': True},
'oauth_scopes': 'badge', 'oauth_scopes': 'badge',
'expire_time': {'$gt': now}, 'expire_time': {'$gt': now}, # TODO(Sybren): save real token expiry time but keep checking tokens hourly when they are used!
}}, }},
{'$lookup': { {'$lookup': {
'from': 'users', 'from': 'users',
@ -62,7 +62,6 @@ def find_users_to_sync() -> typing.Iterable[SyncUser]:
'token': True, 'token': True,
'user._id': True, 'user._id': True,
'user.auth.user_id': True, 'user.auth.user_id': True,
'user.badges.expires': True,
}}, }},
]) ])
@ -101,6 +100,7 @@ def fetch_badge_html(session: requests.Session, user: SyncUser, size: str) \
my_log.debug('No badges for user %s', user.user_id) my_log.debug('No badges for user %s', user.user_id)
return '' return ''
if resp.status_code == 403: if resp.status_code == 403:
# TODO(Sybren): this indicates the token is invalid, so we could just as well delete it.
my_log.warning('Tried fetching %s for user %s but received a 403: %s', my_log.warning('Tried fetching %s for user %s but received a 403: %s',
url, user.user_id, resp.text) url, user.user_id, resp.text)
return '' return ''