Arye Ramaty aryeramaty
0 Followers · 0 Following
  • Joined on 2018-06-10
Repositories
1
 Projects Public Activity Starred Repositories
Arye Ramaty pushed to WIP-realize-depth at aryeramaty/blender 2024-05-02 07:52:14 +02:00
e0b1bb8a45 Take the geometry by const reference.
87fd22f209 Materialized is the default preset
Compare 2 commits »
Arye Ramaty commented on pull request blender/blender#116582 2024-05-01 15:15:21 +02:00
Geometry Nodes: Add selection and depth options to realize instances

I believe I've addressed all the comments. Apologies for the delay; David and I had some things last week that slowed us down. Thanks again for your time, Hans and Jacques.

Arye Ramaty commented on pull request blender/blender#116582 2024-05-01 15:02:30 +02:00
Geometry Nodes: Add selection and depth options to realize instances

hm... I tried to disable it and see if I could locate any wrong behavior, I remember there was a reason for it but I'm not sure anymore. On another note, I have found a bug that if one of the…

Arye Ramaty pushed to WIP-realize-depth at aryeramaty/blender 2024-05-01 14:55:46 +02:00
798d47e585 Make format
093dc1b4c0 Do you have a specific example where this condition might be true?
Compare 2 commits »
Arye Ramaty pushed to WIP-realize-depth at aryeramaty/blender 2024-05-01 14:16:03 +02:00
080ebfcf48 position might not be a special case here anymore.
be856674eb No need to use AllSpanOrSingle
56c02b5fa7 Use const reference.
8e79221c61 revert keep_original_ids -> options
c784dd898f fill_assign_n instead of array_utils::copy
Compare 5 commits »
Arye Ramaty opened issue blender/blender#121295 2024-05-01 11:12:01 +02:00
Edge length overlay disapear in a specific workspace
Arye Ramaty pushed to WIP-realize-depth at aryeramaty/blender 2024-04-30 16:53:42 +02:00
bdf8e9692a Use reference.
9e67e2d1e5 'What does re stand for?'
98bf5c9167 Seems like this should be moved into the lambda above
357f59da6a Use indices.foreach_*.
ba52ebc861 Redundant parentheses
Compare 9 commits »
Arye Ramaty pushed to WIP-realize-depth at aryeramaty/blender 2024-04-30 15:14:33 +02:00
857d0b2cd6 overrided -> overridden
2886495699 typo compent
fafc4aeffa Comment style
9e2b36cb64 Use const
f7ddd14b6d Use Span
Compare 17 commits »
Arye Ramaty commented on pull request blender/blender#116582 2024-04-30 10:10:23 +02:00
Geometry Nodes: Add selection and depth options to realize instances

That was the case in earlier revisions, but we need to execute the attribute_foreach either way. For example, in cases where there are multiple children with relevant attributes, terminating the…

Arye Ramaty commented on pull request blender/blender#116582 2024-04-24 06:50:56 +02:00
Geometry Nodes: Add selection and depth options to realize instances

Indeed, if you look at the commit history you can see the last commits by David.

Arye Ramaty pushed to WIP-realize-depth at aryeramaty/blender 2024-04-22 11:18:12 +02:00
fae1262203 Realize depth code review fixes
702784e07c Better explaning a part of execute_instances_tasks
317e703221 Change to the realize all field tool tip
8afa69f54b Fixes to compiler error
78c758b4e6 Fixed static placment in a function decleration
Compare 11 commits »
Arye Ramaty merged pull request aryeramaty/blender#6 2024-04-22 11:18:11 +02:00
Realize depth code review fixes
Arye Ramaty commented on pull request blender/blender#116582 2024-04-16 17:43:10 +02:00
Geometry Nodes: Add selection and depth options to realize instances

What about: Realize all levels of nested instances for a top-level instances.\nNote: Override the value of the Depth input

Arye Ramaty pushed to WIP-realize-depth at aryeramaty/blender 2024-04-15 16:35:08 +02:00
37c4bc8ab3 There's actually no need to handle location differently
Arye Ramaty pushed to WIP-realize-depth at aryeramaty/blender 2024-04-15 16:31:45 +02:00
a961f2ed70 Fix: Wrong order of transformation multiplication
Arye Ramaty pushed to WIP-realize-depth at aryeramaty/blender 2024-04-10 12:18:48 +02:00
7990d27f12 Fix: Transformation Parent -> child
Arye Ramaty pushed to WIP-realize-depth at aryeramaty/blender 2024-04-06 21:44:51 +02:00
17d675a436 Fix: Wrong use of IndexMask
Arye Ramaty pushed to WIP-realize-depth at aryeramaty/blender 2024-03-31 17:22:51 +02:00
778787b3f5 realize-depth
0bc454422f moved fields were possable instead of givng them by value
8bdb437601 inital commit for the new branch
3ee460f7cb Merge branch 'WIP-realize-depth' of https://projects.blender.org/aryeramaty/blender into realize-depth
ef22826a3c Cleanup: Remove non-creatable option for builtin attributes
Compare 44 commits »
Arye Ramaty merged pull request aryeramaty/blender#5 2024-03-31 17:22:49 +02:00
realize-depth
Arye Ramaty commented on pull request blender/blender#116582 2024-03-25 14:29:34 +01:00
Geometry Nodes: Add selection and depth options to realize instances

@mod_moder hmm... I am not sure I am following the idea here. If I understand correctly, there are three things I am unsure about:

  1. What is the meaning of 'top selected instance' if you…