blender
/
blender-addons-contrib
Archived
3
9
Fork 17
Code Pull Requests 3 Activity

Make checkbox for not installed extensions disabled with tooltip #25

Closed
Dalai Felinto wants to merge 1 commits from dfelinto/blender-addons-contrib:disabled-checkboxes into main
pull from: dfelinto/blender-addons-contrib:disabled-checkboxes
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 5 Commits 1 Files Changed 1 +18 -1
Dalai Felinto commented 2024-02-13 09:32:36 +01:00
Owner
Copy Link

This is a bit of a hack, but not sure if we have a better way to implement this at the moment.

The idea is that an installed extension checkbox should look different than a not installed one,
since you cannot enable/disable the latter.

image

This is a bit of a hack, but not sure if we have a better way to implement this at the moment. The idea is that an installed extension checkbox should look different than a not installed one, since you cannot enable/disable the latter. ----------------------- ![image](/attachments/ee44e850-05ba-41ed-a415-d8931f3b6a03)
image.png
83 KiB
Dalai Felinto added 1 commit 2024-02-13 09:32:38 +01:00
3cc4345f1e Make checkbox for not installed extensions disabled with tooltip 
This is a bit of a hack, but not sure if we have a better way to implement this at the moment.

The idea is that an installed extension checkbox should look different than a not installed one,
since you cannot enable/disable the latter.
Dalai Felinto requested review from Campbell Barton 2024-02-13 09:32:48 +01:00
Dalai Felinto commented 2024-02-13 09:33:08 +01:00
Author
Owner
Copy Link

Take this as a proof of concept if you will. But I wanted to show how I would imagine the checkboxes should look like.

Take this as a proof of concept if you will. But I wanted to show how I would imagine the checkboxes should look like.
Dalai Felinto commented 2024-02-14 08:05:19 +01:00
Author
Owner
Copy Link

An alternative is to use a (fake) property instead. For disabled properties we have a more clear tooltip that hints at being an error

An alternative is to use a (fake) property instead. For disabled properties we have a more clear tooltip that hints at being an error
Campbell Barton commented 2024-02-20 04:16:24 +01:00
Owner
Copy Link

Committed with minor edits.

Committed with minor edits.
Campbell Barton closed this pull request 2024-02-20 04:16:25 +01:00
Dalai Felinto commented 2024-02-20 08:13:13 +01:00
Author
Owner
Copy Link

@ideasman42 thanks for the commit :)

I think there is a typo, no?

- BlPkgPkgEnableNotInstalled
+ BlPkgEnableNotInstalled
@ideasman42 thanks for the commit :) I think there is a typo, no? ``` - BlPkgPkgEnableNotInstalled + BlPkgEnableNotInstalled ```
Campbell Barton commented 2024-02-20 08:39:52 +01:00
Owner
Copy Link

@dfelinto yep, corrected.

@dfelinto yep, corrected.
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Campbell Barton
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons-contrib#25
No description provided.
Delete Branch "dfelinto/blender-addons-contrib:disabled-checkboxes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?