Bsurfaces addon stopped working (probably after the new Retopology Overlay addition) #104484

New Issue

antonheg · 2023-03-14T12:39:13+01:00

antonheg commented

2023-03-14 12:39:13 +01:00

System Information
Operating system: macOS Monterey 12.6.2
Graphics card: Intel HD Graphics 530 / Radeon Pro 450

Blender Version
Broken: Blender 3.6.0 - Alpha - Intel
Worked: Blender 3.5

Addon Information
Name: Bsurfaces GPL Edition (1, 8, 1)
Author: Eclectiel, Vladimir Spivak (cwolf3d)

Short description of error
No mesh is being generated

Exact steps for others to reproduce the error

Add a UV Sphere
Initialize Bsurface Mesh
Use either Annotation or GPencil
Click Add Surface

Nothing happens (i.e. no mesh is being generated).

I'm testing this with the Metal Backend and first noticed this behaviour after the (otherwise really awesome) Retopology Overlay was added to Blender 3.6.0 - Alpha.

Looking at the commit, it seems to me that "use_hidden_wire" was replaced with "use_retopology" on which Bsurfaces and probably other addons were relying.

Thank you

**System Information** Operating system: macOS Monterey 12.6.2 Graphics card: Intel HD Graphics 530 / Radeon Pro 450 **Blender Version** Broken: Blender 3.6.0 - Alpha - Intel Worked: Blender 3.5 **Addon Information** Name: Bsurfaces GPL Edition (1, 8, 1) Author: Eclectiel, Vladimir Spivak (cwolf3d) **Short description of error** No mesh is being generated **Exact steps for others to reproduce the error** 1. Add a UV Sphere 2. Initialize Bsurface Mesh 3. Use either Annotation or GPencil 4. Click Add Surface Nothing happens (i.e. no mesh is being generated). I'm testing this with the **Metal Backend** and first noticed this behaviour after the (otherwise really awesome) [Retopology Overlay](https://projects.blender.org/blender/blender/pulls/104599#issuecomment-897657) was added to Blender 3.6.0 - Alpha. Looking at the commit, it seems to me that "use_hidden_wire" was replaced with "use_retopology" on which Bsurfaces and probably other addons were relying. Thank you

antonheg added the

labels 2023-03-14 12:39:14 +01:00

antonheg changed title from ~~Bsurfaces addon stopped working (probably after the new retopology overlay addition)~~ to Bsurfaces addon stopped working (probably after the new Retopology Overlay addition)

2023-03-14 20:17:49 +01:00

antonheg referenced this issue from blender/blender

2023-03-14 20:23:31 +01:00

#70267 Retopology Overlay #104599

Jorijn de Graaf commented

2023-03-14 20:54:43 +01:00

None of the addons that come with Blender use the old show_occlude_wire or the new show_retopology.
Neither use_hidden_wire nor use_retopology ever existed.
My guess is the issue has something to do with the deprecation of passing in context overrides in favor of using Context.temp_override, because the console is filled with warnings about that when using Bsurfaces.
I'll go investigate this now.
Edit: That wasn't it, though it is nice getting rid of console warnings.

None of the addons that come with Blender use the old `show_occlude_wire` or the new `show_retopology`. Neither `use_hidden_wire` nor `use_retopology` ever existed. My guess is the issue has something to do with the deprecation of passing in context overrides in favor of using `Context.temp_override`, because the console is filled with warnings about that when using Bsurfaces. I'll go investigate this now. Edit: That wasn't it, though it is nice getting rid of console warnings.

~~Jorijn de Graaf referenced this issue 2023-03-14 21:23:46 +01:00~~

Bsurfaces: Use context temp override to avoid deprecation #104486

Jorijn de Graaf commented

2023-03-14 22:11:22 +01:00

Going all the way back to https://projects.blender.org/bonj/blender/src/branch/retopology-overlay does fix it, so the retopology overlay isn't what broke the addon.
I guess that means something else introduced in the last 2 weeks broke it.
Update: the commit that broke it is 1658de6769.
At least that's the first one where it breaks when you check out.
Reverting the changes doesn't actually fix it, so I have no idea what's going on.

Going all the way back to https://projects.blender.org/bonj/blender/src/branch/retopology-overlay does fix it, so the retopology overlay isn't what broke the addon. I guess that means something else introduced in the last 2 weeks broke it. Update: the commit that broke it is https://projects.blender.org/blender/blender/commit/1658de6769b1d6ada4cab546a313ff5a6ae36fb1. At least that's the first one where it breaks when you check out. Reverting the changes doesn't actually fix it, so I have no idea what's going on.

antonheg commented

2023-03-15 21:59:55 +01:00

@bonj your efforts are very well invested as Bsurfaces is a precious addon for the very people interested in your awesome retopology overlay. I believe it's important to understand what broke it while the issue is still fresh. It's frustrating that even reverting that commit isn't enough to get it back to normal. Nothing in that commit seems related to its functions. What else can that be, I wonder.

Jorijn de Graaf commented

2023-03-15 23:35:57 +01:00

I think the reason it's not working is because convert mesh to curve is broken; it generates empty splines.
I found this out by going through Bsurfaces to find where in the code it goes wrong.

I think the reason it's not working is because convert mesh to curve is broken; it generates empty splines. I found this out by going through Bsurfaces to find where in the code it goes wrong.

antonheg commented

2023-03-16 09:27:47 +01:00

Where do we go from here? I can't believe we just lost the Bsurfaces addon. Without it, retopology is pretty much dead on Blender despite your new retopology overlay.

Will this issue be escalated to encompass the original addon developers?

Where do we go from here? I can't believe we just lost the Bsurfaces addon. Without it, retopology is pretty much dead on Blender despite your new retopology overlay. Will this issue be escalated to encompass the original addon developers?

Jorijn de Graaf commented

2023-03-16 17:44:49 +01:00

I've spent a few hours fixing the convert mesh to curves operator, so after that is merged Bsurfaces will work again.
Here's the pull request: blender/blender#105838.

I've spent a few hours fixing the convert mesh to curves operator, so after that is merged Bsurfaces will work again. Here's the pull request: https://projects.blender.org/blender/blender/pulls/105838.

👍 2 🎉 2

~~Jorijn de Graaf referenced this issue 2023-03-16 17:47:15 +01:00~~

Bsurfaces: Use context temp override to avoid deprecation #104486

~~Jorijn de Graaf referenced this issue 2023-03-16 17:47:27 +01:00~~

Bsurfaces: Use context temp override to avoid deprecation #104486

Jorijn de Graaf referenced this issue

2023-03-16 17:49:22 +01:00

Bsurfaces: Use context temp override to avoid deprecation #104486

antonheg commented

2023-03-16 17:54:09 +01:00

Seriously, this was not an easy one. You did an amazing job!

Thank you very much

Seriously, this was not an easy one. You did an amazing job! Thank you very much

❤️ 1

Jorijn de Graaf commented

2023-03-18 03:53:15 +01:00

@antonheg Alright the fix got merged, so this issue should be solved now.
Would you mind closing the issue as resolved? I can't do it cause I didn't open the issue, and am not a maintainer.

@antonheg Alright the fix got merged, so this issue should be solved now. Would you mind closing the issue as resolved? I can't do it cause I didn't open the issue, and am not a maintainer.

antonheg commented

2023-03-18 07:49:33 +01:00

Great, thanks again.

antonheg closed this issue

2023-03-18 07:49:34 +01:00

Blender Bot added

and removed

labels 2023-03-18 07:49:35 +01:00