blender/blender-addons
19
43
Fork 96
Code Issues 631 Pull Requests 27 Projects 1 Releases Wiki Activity

Bsurfaces addon stopped working (probably after the new Retopology Overlay addition) #104484

New Issue
Closed
opened 2023-03-14 12:39:13 +01:00 by antonheg · 9 comments
antonheg commented 2023-03-14 12:39:13 +01:00
Copy Link

System Information
Operating system: macOS Monterey 12.6.2
Graphics card: Intel HD Graphics 530 / Radeon Pro 450

Blender Version
Broken: Blender 3.6.0 - Alpha - Intel
Worked: Blender 3.5

Addon Information
Name: Bsurfaces GPL Edition (1, 8, 1)
Author: Eclectiel, Vladimir Spivak (cwolf3d)

Short description of error
No mesh is being generated

Exact steps for others to reproduce the error

  1. Add a UV Sphere
  2. Initialize Bsurface Mesh
  3. Use either Annotation or GPencil
  4. Click Add Surface

Nothing happens (i.e. no mesh is being generated).

I'm testing this with the Metal Backend and first noticed this behaviour after the (otherwise really awesome) Retopology Overlay was added to Blender 3.6.0 - Alpha.

Looking at the commit, it seems to me that "use_hidden_wire" was replaced with "use_retopology" on which Bsurfaces and probably other addons were relying.

Thank you

**System Information** Operating system: macOS Monterey 12.6.2 Graphics card: Intel HD Graphics 530 / Radeon Pro 450 **Blender Version** Broken: Blender 3.6.0 - Alpha - Intel Worked: Blender 3.5 **Addon Information** Name: Bsurfaces GPL Edition (1, 8, 1) Author: Eclectiel, Vladimir Spivak (cwolf3d) **Short description of error** No mesh is being generated **Exact steps for others to reproduce the error** 1. Add a UV Sphere 2. Initialize Bsurface Mesh 3. Use either Annotation or GPencil 4. Click Add Surface Nothing happens (i.e. no mesh is being generated). I'm testing this with the **Metal Backend** and first noticed this behaviour after the (otherwise really awesome) [Retopology Overlay](https://projects.blender.org/blender/blender/pulls/104599#issuecomment-897657) was added to Blender 3.6.0 - Alpha. Looking at the commit, it seems to me that "use_hidden_wire" was replaced with "use_retopology" on which Bsurfaces and probably other addons were relying. Thank you
antonheg added the
Priority
Normal
Status
Needs Triage
Type
Report
 labels 2023-03-14 12:39:14 +01:00
antonheg changed title from Bsurfaces addon stopped working (probably after the new retopology overlay addition) to Bsurfaces addon stopped working (probably after the new Retopology Overlay addition) 2023-03-14 20:17:49 +01:00
Jorijn de Graaf commented 2023-03-14 20:54:43 +01:00
Copy Link

None of the addons that come with Blender use the old show_occlude_wire or the new show_retopology.
Neither use_hidden_wire nor use_retopology ever existed.
My guess is the issue has something to do with the deprecation of passing in context overrides in favor of using Context.temp_override, because the console is filled with warnings about that when using Bsurfaces.
I'll go investigate this now.
Edit: That wasn't it, though it is nice getting rid of console warnings.

None of the addons that come with Blender use the old `show_occlude_wire` or the new `show_retopology`. Neither `use_hidden_wire` nor `use_retopology` ever existed. My guess is the issue has something to do with the deprecation of passing in context overrides in favor of using `Context.temp_override`, because the console is filled with warnings about that when using Bsurfaces. I'll go investigate this now. Edit: That wasn't it, though it is nice getting rid of console warnings.
Jorijn de Graaf commented 2023-03-14 22:11:22 +01:00
Copy Link

Going all the way back to https://projects.blender.org/bonj/blender/src/branch/retopology-overlay does fix it, so the retopology overlay isn't what broke the addon.
I guess that means something else introduced in the last 2 weeks broke it.
Update: the commit that broke it is 1658de6769.
At least that's the first one where it breaks when you check out.
Reverting the changes doesn't actually fix it, so I have no idea what's going on.

Going all the way back to https://projects.blender.org/bonj/blender/src/branch/retopology-overlay does fix it, so the retopology overlay isn't what broke the addon. I guess that means something else introduced in the last 2 weeks broke it. Update: the commit that broke it is https://projects.blender.org/blender/blender/commit/1658de6769b1d6ada4cab546a313ff5a6ae36fb1. At least that's the first one where it breaks when you check out. Reverting the changes doesn't actually fix it, so I have no idea what's going on.
antonheg commented 2023-03-15 21:59:55 +01:00
Author
Copy Link

@bonj your efforts are very well invested as Bsurfaces is a precious addon for the very people interested in your awesome retopology overlay. I believe it's important to understand what broke it while the issue is still fresh. It's frustrating that even reverting that commit isn't enough to get it back to normal. Nothing in that commit seems related to its functions. What else can that be, I wonder.

@bonj your efforts are very well invested as Bsurfaces is a precious addon for the very people interested in your awesome retopology overlay. I believe it's important to understand what broke it while the issue is still fresh. It's frustrating that even reverting that commit isn't enough to get it back to normal. Nothing in that commit seems related to its functions. What else can that be, I wonder.
Jorijn de Graaf commented 2023-03-15 23:35:57 +01:00
Copy Link

I think the reason it's not working is because convert mesh to curve is broken; it generates empty splines.
I found this out by going through Bsurfaces to find where in the code it goes wrong.

I think the reason it's not working is because convert mesh to curve is broken; it generates empty splines. I found this out by going through Bsurfaces to find where in the code it goes wrong.
antonheg commented 2023-03-16 09:27:47 +01:00
Author
Copy Link

Where do we go from here? I can't believe we just lost the Bsurfaces addon. Without it, retopology is pretty much dead on Blender despite your new retopology overlay.

Will this issue be escalated to encompass the original addon developers?

Where do we go from here? I can't believe we just lost the Bsurfaces addon. Without it, retopology is pretty much dead on Blender despite your new retopology overlay. Will this issue be escalated to encompass the original addon developers?
Jorijn de Graaf commented 2023-03-16 17:44:49 +01:00
Copy Link

I've spent a few hours fixing the convert mesh to curves operator, so after that is merged Bsurfaces will work again.
Here's the pull request: blender/blender#105838.

I've spent a few hours fixing the convert mesh to curves operator, so after that is merged Bsurfaces will work again. Here's the pull request: https://projects.blender.org/blender/blender/pulls/105838.
👍 2 🎉 2
antonheg commented 2023-03-16 17:54:09 +01:00
Author
Copy Link

Seriously, this was not an easy one. You did an amazing job!

Thank you very much

Seriously, this was not an easy one. You did an amazing job! Thank you very much
❤️ 1
Jorijn de Graaf commented 2023-03-18 03:53:15 +01:00
Copy Link

@antonheg Alright the fix got merged, so this issue should be solved now.
Would you mind closing the issue as resolved? I can't do it cause I didn't open the issue, and am not a maintainer.

@antonheg Alright the fix got merged, so this issue should be solved now. Would you mind closing the issue as resolved? I can't do it cause I didn't open the issue, and am not a maintainer.
antonheg commented 2023-03-18 07:49:33 +01:00
Author
Copy Link

Great, thanks again.

Great, thanks again.
Blender Bot added
Status
Archived
 and removed
Status
Needs Triage
 labels 2023-03-18 07:49:35 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#104484
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?