blender/blender-addons
19
43
Fork 96
Code Issues 629 Pull Requests 27 Projects 1 Releases Wiki Activity

Bsurfaces: Use context temp override to avoid deprecation #104486

Closed
Jorijn de Graaf wants to merge 4 commits from bonj/blender-addons:fix/bsurfaces into main
pull from: bonj/blender-addons:fix/bsurfaces
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 3 Commits 4 Files Changed 1 +24 -13
Jorijn de Graaf commented 2023-03-14 21:23:46 +01:00
First-time contributor
Copy Link

Passing context override to operators is deprecated in favor of Context.temp_override.
The console warnings were annoying, and in the future it would have stopped working entirely.
I used EXEC_REGION_WIN to be consistent with how the rest of the addon calls operators.

Passing context override to operators is deprecated in favor of Context.temp_override. The console warnings were annoying, and in the future it would have stopped working entirely. I used EXEC_REGION_WIN to be consistent with how the rest of the addon calls operators.
Jorijn de Graaf added 1 commit 2023-03-14 21:23:48 +01:00 
Passing context override to operators is deprecated in favor of Context.temp_override.
I used EXEC_REGION_WIN to be consistent with how the rest of the addon calls operators.
Jorijn de Graaf requested review from Vladimir Spivak 2023-03-14 21:31:26 +01:00
Jorijn de Graaf added 1 commit 2023-03-14 21:38:01 +01:00 
Context.temp_override was introduced in Blender 3.2, so I'm making that the minimum Blender version.
I'll also bump the addon version, because changes were made and it'd be confusing not to change the version too then.
Jorijn de Graaf changed title from Fix #104484: Bsurfaces addon stopped working to WIP: Fix #104484: Bsurfaces addon stopped working 2023-03-14 21:57:22 +01:00
Jorijn de Graaf changed title from WIP: Fix #104484: Bsurfaces addon stopped working to Bsurfaces: Use context temp override to avoid deprecation 2023-03-16 17:45:36 +01:00
Jorijn de Graaf added 1 commit 2023-03-16 17:48:26 +01:00
Jorijn de Graaf commented 2023-03-16 17:49:22 +01:00
Author
First-time contributor
Copy Link

Previously I thought this PR was going to solve #104484, but that requires changes to Blender itself, so I'm changing the name and purpose of this PR instead of throwing it away.

Previously I thought this PR was going to solve #104484, but that requires changes to Blender itself, so I'm changing the name and purpose of this PR instead of throwing it away.
Jorijn de Graaf added 1 commit 2023-03-22 00:54:19 +01:00
Damien Picard commented 2023-12-18 14:24:14 +01:00
Member
Copy Link

@bonj This was fixed in a slightly different way in e22637d5ba.

@bonj This was fixed in a slightly different way in e22637d5ba.
Jorijn de Graaf commented 2023-12-18 14:39:27 +01:00
Author
First-time contributor
Copy Link

Excellent, I'll close this PR then.

Excellent, I'll close this PR then.
👍 1
Jorijn de Graaf closed this pull request 2023-12-18 14:39:27 +01:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Vladimir Spivak
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#104486
No description provided.
Delete Branch "bonj/blender-addons:fix/bsurfaces"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?