blender/blender-addons
19
43
Fork 96
Code Issues 634 Pull Requests 27 Projects 1 Releases Wiki Activity

Magic UV: Get nodes with their types instead of names #104402

Merged
nutti merged 1 commits from pioverfour/blender-addons:dp_fix_new_mat_issue_magicuv into main 2023-02-11 01:33:23 +01:00
Conversation 3 Commits 1 Files Changed 2 +4 -2
Damien Picard commented 2023-02-09 21:29:37 +01:00
Member
Copy Link

Using hardcoded names to retrieve nodes can result in errors if the
user has enabled UI translation, because the new nodes may not have
the expected English names.

Instead, we retrieve the nodes using their types (BSDF_PRINCIPLED or
OUTPUT_MATERIAL).

Ref blender/blender#104145

Using hardcoded names to retrieve nodes can result in errors if the user has enabled UI translation, because the new nodes may not have the expected English names. Instead, we retrieve the nodes using their types (BSDF_PRINCIPLED or OUTPUT_MATERIAL). Ref blender/blender#104145
Damien Picard force-pushed dp_fix_new_mat_issue_magicuv from 8485a747dc to c7add56b08 2023-02-09 21:31:26 +01:00 Compare
Damien Picard requested review from nutti 2023-02-09 21:31:49 +01:00
nutti requested changes 2023-02-10 07:49:33 +01:00
nutti left a comment
Member
Copy Link

Thanks for your patch.
I have few requests for this patch.
Could you check my comments?

Thanks for your patch. I have few requests for this patch. Could you check my comments?
👍 1
magic_uv/__init__.py
@ -3,3 +3,3 @@
__author__ = "Nutti <nutti.metro@gmail.com>"
__status__ = "production"
__version__ = "6.7"
__version__ = "6.8"
nutti commented 2023-02-10 07:48:22 +01:00
Member
Copy Link

Could you revert version to 6.7?
I'm considering to update the version when some patches are merged.

Could you revert version to `6.7`? I'm considering to update the version when some patches are merged.
pioverfour marked this conversation as resolved
magic_uv/__init__.py
@ -13,3 +13,3 @@
"Alexander Milovsky, Dusan Stevanovic, MatthiasThDs, "
"theCryingMan, PratikBorhade302",
"version": (6, 7, 0),
"version": (6, 8, 0),
nutti commented 2023-02-10 07:48:34 +01:00
Member
Copy Link

Same here.
Could you revert version to 6.7?
I'm considering to update the version when some patches are merged.

Same here. Could you revert version to `6.7`? I'm considering to update the version when some patches are merged.
pioverfour marked this conversation as resolved
Damien Picard force-pushed dp_fix_new_mat_issue_magicuv from c7add56b08 to cd5d278353 2023-02-10 10:20:08 +01:00 Compare
Damien Picard commented 2023-02-10 11:40:46 +01:00
Author
Member
Copy Link

I’ve reverted to the previous version number. Do you want me to merge this or would you rather handle it yourself, since you’ve got another repo at GitHub and all?

I’ve reverted to the previous version number. Do you want me to merge this or would you rather handle it yourself, since you’ve got another repo at GitHub and all?
nutti approved these changes 2023-02-11 01:32:41 +01:00
nutti merged commit 8fb28124ba into main 2023-02-11 01:33:23 +01:00
nutti commented 2023-02-11 01:37:10 +01:00
Member
Copy Link

@pioverfour

Thanks for your patch. Merged.

Do you want me to merge this or would you rather handle it yourself, since you’ve got another repo at GitHub and all?

I sometime merge the changes from this repository to GitHub one.
If you want, you can send the patch to the repo at GitHub as well.

https://github.com/nutti/Magic-UV/pulls

@pioverfour Thanks for your patch. Merged. > Do you want me to merge this or would you rather handle it yourself, since you’ve got another repo at GitHub and all? I sometime merge the changes from this repository to GitHub one. If you want, you can send the patch to the repo at GitHub as well. https://github.com/nutti/Magic-UV/pulls
Damien Picard deleted branch dp_fix_new_mat_issue_magicuv 2023-02-11 19:08:32 +01:00
Damien Picard commented 2023-02-11 19:09:35 +01:00
Author
Member
Copy Link

I sometime merge the changes from this repository to GitHub one.
If you want, you can send the patch to the repo at GitHub as well.

I’ll let you handle the GitHub side :)

> I sometime merge the changes from this repository to GitHub one. > If you want, you can send the patch to the repo at GitHub as well. I’ll let you handle the GitHub side :)
Sign in to join this conversation.
Reviewers
No reviewers
nutti
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#104402
No description provided.
Delete Branch "pioverfour/blender-addons:dp_fix_new_mat_issue_magicuv"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?