blender/blender-addons
19
43
Fork 96
Code Issues 633 Pull Requests 27 Projects 1 Releases Wiki Activity

Option to prioritize active color at export #104435

Closed
Andrej wants to merge 2 commits from (deleted):fbx_prioritize_active_color into main
pull from: (deleted):fbx_prioritize_active_color
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 1 Commits 2 Files Changed 3 +16 -3
Andrej commented 2023-02-25 13:07:40 +01:00
Contributor
Copy Link

Basically some software (like 3ds Max or Substance Painter) discard other color attributes besides the first one - so the option to prioritize active_color to be exportred first will be helpful in these cases. It is especially important since currently there is no option to move color attributes around in Blender.

Explained it in details here - blender/blender#104827

To solve that I've added that option in FBX exporter.

Basically some software (like 3ds Max or Substance Painter) discard other color attributes besides the first one - so the option to prioritize active_color to be exportred first will be helpful in these cases. It is especially important since currently there is no option to move color attributes around in Blender. Explained it in details here - https://projects.blender.org/blender/blender/issues/104827 To solve that I've added that option in FBX exporter.
Andrej requested review from Bastien Montagne 2023-02-25 13:08:00 +01:00
Bastien Montagne force-pushed fbx_prioritize_active_color from 4f786ef3f6 to a9c30a5811 2023-03-06 16:22:05 +01:00 Compare
Bastien Montagne requested changes 2023-03-06 16:24:45 +01:00
Bastien Montagne left a comment
Owner
Copy Link

besides note below, LGTM :)

besides note below, LGTM :)
io_scene_fbx/__init__.py
@ -485,0 +486,4 @@
name="Prioritize Active Color",
description="Make sure active color will be exported first. Could be important "
"since some other software can discard other color attributes besides the first one "
"(e.g. 3ds Max, Substance Painter)",
Bastien Montagne commented 2023-03-06 16:22:57 +01:00
Owner
Copy Link

No closed-source software names please, this can cause copyright etc. issues. ;)

No closed-source software names please, this can cause copyright etc. issues. ;)
Andrej commented 2023-03-06 16:44:38 +01:00
Author
Contributor
Copy Link

That information could save some time to users but I guess it's better to be safe than sorry 🥲

That information could save some time to users but I guess it's better to be safe than sorry 🥲
Bastien Montagne commented 2023-03-06 17:41:52 +01:00
Owner
Copy Link

Indeed (also, no end point in UI messages ;) )

Indeed (also, no end point in UI messages ;) )
Andrej added 1 commit 2023-03-06 16:43:51 +01:00
Andrej requested review from Bastien Montagne 2023-03-06 16:44:54 +01:00
Bastien Montagne approved these changes 2023-03-06 17:41:58 +01:00
Bastien Montagne left a comment
Owner
Copy Link

LGTM

LGTM
Bastien Montagne commented 2023-03-06 17:52:46 +01:00
Owner
Copy Link

Committed as 4c397ede41.

Committed as 4c397ede41d027d9f0a.
Bastien Montagne closed this pull request 2023-03-06 17:52:49 +01:00
Bastien Montagne deleted branch fbx_prioritize_active_color 2023-03-15 11:59:53 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Bastien Montagne
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#104435
No description provided.
Delete Branch "(deleted):fbx_prioritize_active_color"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?