blender/blender-addons
19
43
Fork 96
Code Issues 630 Pull Requests 27 Projects 1 Releases Wiki Activity

Node Wrangler: Add support for texturecan texture imports #104442

Closed
Johan Walles wants to merge 2 commits from Walles:johan/no-directx-map into main
pull from: Walles:johan/no-directx-map
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 3 Commits 2 Files Changed 3 +38 -2
Johan Walles commented 2023-02-27 06:25:24 +01:00
Contributor
Copy Link

Fix for Node Wrangler's "Add Principled Setup".

Before this change, if you tried to "Add Principled Setup" for this material, Node Wrangler used metal_0010_normal_directx_1k.png for the normal map.

That's a bad choice however, since Blender wants OpenGL style normal maps.

With this change in place, "Add Principled Setup" now correctly picks metal_0010_normal_opengl_1k.png for the normal map.

Additionally, this change adds a (very) short README with instructions for how to run the Node Wrangler tests.

Fix for Node Wrangler's "Add Principled Setup". Before this change, if you tried to "Add Principled Setup" for [this material](https://www.texturecan.com/details/67/), Node Wrangler used `metal_0010_normal_directx_1k.png` for the normal map. That's a bad choice however, since Blender wants OpenGL style normal maps. With this change in place, "Add Principled Setup" now correctly picks `metal_0010_normal_opengl_1k.png` for the normal map. Additionally, this change adds a (very) short README with instructions for how to run the Node Wrangler tests.
Johan Walles added 2 commits 2023-02-27 06:25:26 +01:00
Johan Walles requested review from Brecht Van Lommel 2023-02-27 06:25:57 +01:00
Johan Walles commented 2023-02-27 06:30:06 +01:00
Author
Contributor
Copy Link

@brecht added you as a reviewer since you reviewed my previous change on the same topic: c0a678d368

@brecht added you as a reviewer since you reviewed my previous change on the same topic: c0a678d3686a591eb3041cc72b60aec2857d389a
Brecht Van Lommel approved these changes 2023-02-27 11:02:06 +01:00
Brecht Van Lommel commented 2023-02-27 11:03:09 +01:00
Owner
Copy Link

This looks good, but also would make sense as a bugfix for Blender 3.5.

If you think that makes sense, you can use these instructions to retarget this branch to blender-v3.5-release.
https://wiki.blender.org/wiki/Tools/Pull_Requests#Rebasing_a_Pull_Request

This looks good, but also would make sense as a bugfix for Blender 3.5. If you think that makes sense, you can use these instructions to retarget this branch to `blender-v3.5-release`. https://wiki.blender.org/wiki/Tools/Pull_Requests#Rebasing_a_Pull_Request
Johan Walles commented 2023-02-27 17:39:23 +01:00
Author
Contributor
Copy Link

Replaced by #104445 which goes into blender-v3.5-release instead.

Replaced by #104445 which goes into `blender-v3.5-release` instead.
Johan Walles closed this pull request 2023-02-27 17:39:26 +01:00
Johan Walles deleted branch johan/no-directx-map 2023-02-27 18:36:47 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Brecht Van Lommel
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#104442
No description provided.
Delete Branch "Walles:johan/no-directx-map"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?