blender/blender-addons
19
43
Fork 96
Code Issues 634 Pull Requests 27 Projects 1 Releases Wiki Activity

Archimesh: fix floor creation #104446

Merged
Damien Picard merged 1 commits from pioverfour/blender-addons:dp_archimesh_fix_mods into blender-v3.5-release 2023-02-28 10:40:00 +01:00
Conversation 4 Commits 1 Files Changed 2 +26 -29
Damien Picard commented 2023-02-27 20:25:51 +01:00
Member
Copy Link

The option to create a floor was broken for a long time, because it
relied on the presence of a Diffuse BSDF in a new material, however it
has been replaced by the Principled BSDF long ago.

Additionally, use the data API to create the modifiers instead of the
ops API, and assign nodes to variables instead of getting them by
name, which will not work any more if the UI is translated.

The option to create a floor was broken for a long time, because it relied on the presence of a Diffuse BSDF in a new material, however it has been replaced by the Principled BSDF long ago. Additionally, use the data API to create the modifiers instead of the ops API, and assign nodes to variables instead of getting them by name, which will not work any more if the UI is translated.
Damien Picard added 1 commit 2023-02-27 20:25:52 +01:00 
The option to create a floor was broken for a long time, because it
relied on the presence of a Diffuse BSDF in a new material, however it
has been replaced by the Principled BSDF long ago.

Additionally, use the data API to create the modifiers instead of the
ops API, and assign nodes to variables instead of getting them by
name, which will not work any more if the UI is translated.
Damien Picard requested review from Antonio Vazquez 2023-02-27 20:26:22 +01:00
Damien Picard changed target branch from main to blender-v3.5-release 2023-02-27 20:29:33 +01:00
Antonio Vazquez approved these changes 2023-02-28 10:05:08 +01:00
Antonio Vazquez left a comment
Member
Copy Link

LGTM... thanks a lot for the fix.

Do you have commit rights? If not, I can merge the Pull Request myself.

LGTM... thanks a lot for the fix. Do you have commit rights? If not, I can merge the Pull Request myself.
Damien Picard merged commit dd91f21836 into blender-v3.5-release 2023-02-28 10:40:00 +01:00
Damien Picard deleted branch dp_archimesh_fix_mods 2023-02-28 10:40:01 +01:00
Damien Picard commented 2023-02-28 10:40:22 +01:00
Author
Member
Copy Link

Do you have commit rights? If not, I can merge the Pull Request myself.

Thank you, I can commit :)

> Do you have commit rights? If not, I can merge the Pull Request myself. Thank you, I can commit :)
Antonio Vazquez commented 2023-02-28 13:30:16 +01:00
Member
Copy Link

@pioverfour @ThomasDinges This Pull Request was merged in 3.5, but I guess it needs to be merged in addons git repo, is that correct? In this case, the commit must be cherrypick to addons git repo too.

@pioverfour @ThomasDinges This Pull Request was merged in 3.5, but I guess it needs to be merged in addons git repo, is that correct? In this case, the commit must be cherrypick to addons git repo too.
Damien Picard commented 2023-02-28 13:31:38 +01:00
Author
Member
Copy Link

@antoniov I don’t think it needs to be cherrypicked, but merged instead. I’ll do it from home tonight if somebody hasn’t until then!

@antoniov I don’t think it needs to be cherrypicked, but merged instead. I’ll do it from home tonight if somebody hasn’t until then!
Thomas Dinges commented 2023-02-28 15:19:28 +01:00
Owner
Copy Link

Yes, the same workflow that applies to Blender applies to add-ons as well. https://wiki.blender.org/wiki/Process/Using_Stabilizing_Branch

Commit to the stabilizing branch (in this case 3.5), and merge to main afterwards.

Yes, the same workflow that applies to Blender applies to add-ons as well. https://wiki.blender.org/wiki/Process/Using_Stabilizing_Branch Commit to the stabilizing branch (in this case 3.5), and merge to main afterwards.
Sign in to join this conversation.
Reviewers
No reviewers
Antonio Vazquez
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#104446
No description provided.
Delete Branch "pioverfour/blender-addons:dp_archimesh_fix_mods"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?