blender/blender-addons
19
43
Fork 96
Code Issues 629 Pull Requests 27 Projects 1 Releases Wiki Activity

WIP add default library_name for unknown platforms #104492

Closed
Shane Ambler wants to merge 1 commits from ShaneAmbler/blender-addons:draco-libname into main
pull from: ShaneAmbler/blender-addons:draco-libname
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 2 Commits 1 Files Changed 1 +1 -1
Shane Ambler commented 2023-03-19 01:52:25 +01:00
First-time contributor
Copy Link

When retrieving the draco libname from the dict, we can set a default value to be used for unknown platform names, leaving entries only for known variations to this naming convention.

The entry for linux could also be removed as it can use this default.

Another possibility is to support an environment variable to configure libname, similar to BLENDER_EXTERN_DRACO_LIBRARY_PATH

When retrieving the draco libname from the dict, we can set a default value to be used for unknown platform names, leaving entries only for known variations to this naming convention. The entry for linux could also be removed as it can use this default. Another possibility is to support an environment variable to configure libname, similar to `BLENDER_EXTERN_DRACO_LIBRARY_PATH`
Shane Ambler added 1 commit 2023-03-19 01:52:27 +01:00
Julien Duroure self-assigned this 2023-03-19 04:14:55 +01:00
Julien Duroure requested changes 2024-05-24 15:59:11 +02:00
io_scene_gltf2/io/com/gltf2_io_draco_compression_extension.py
@ -36,3 +36,3 @@
}.get(sys.platform)
}.get(sys.platform, 'lib{}.so'.format(lib_name))
if path is None or library_name is None:
Julien Duroure commented 2024-05-24 15:59:02 +02:00
Member
Copy Link

Setting a default library name makes this check unrelevant

Setting a default library name makes this check unrelevant
Julien Duroure commented 2024-11-13 11:30:43 +01:00
Member
Copy Link

No news from the contributor since a very long time, closing it.
Feel free to take feedback into account or create a new PR if needed

No news from the contributor since a very long time, closing it. Feel free to take feedback into account or create a new PR if needed
Julien Duroure closed this pull request 2024-11-13 11:30:44 +01:00
Shane Ambler commented 2024-11-13 23:28:47 +01:00
Author
First-time contributor
Copy Link

Well library_name would never be None but path can be None so it could be changed to if path is None:

Well `library_name` would never be None but `path` can be None so it could be changed to `if path is None:`

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Julien Duroure
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
Julien Duroure
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#104492
No description provided.
Delete Branch "ShaneAmbler/blender-addons:draco-libname"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?