blender/blender-addons
19
43
Fork 96
Code Issues 630 Pull Requests 27 Projects 1 Releases Wiki Activity

FBX Import: Speed up cycles decal workaround with numpy #104497

Merged
Bastien Montagne merged 1 commits from Mysteryem/blender-addons:fbx_import_cycles_workaround_np_pr into main 2023-04-03 14:43:06 +02:00
Conversation 1 Commits 1 Files Changed 1 +10 -2
Thomas Barlow commented 2023-03-20 04:09:04 +01:00
Member
Copy Link

Replace iteration with foreach_get/set and numpy vectorized operations

An issue introduced in Blender 3.3 makes the original code very slow:
blender/blender#105909
So this results in about a 1500 times speedup at 6000 vertices and 3500 times at 25000 vertices.

In Blender 3.2 the new code would run about 40-60 times faster for 1000-25000+ vertices.

Replace iteration with foreach_get/set and numpy vectorized operations An issue introduced in Blender 3.3 makes the original code very slow: https://projects.blender.org/blender/blender/issues/105909 So this results in about a 1500 times speedup at 6000 vertices and 3500 times at 25000 vertices. In Blender 3.2 the new code would run about 40-60 times faster for 1000-25000+ vertices.
Thomas Barlow requested review from Bastien Montagne 2023-03-20 04:10:23 +01:00
Bastien Montagne requested changes 2023-03-21 12:13:49 +01:00
Bastien Montagne left a comment
Owner
Copy Link

Patch look good.

Also think that the imports 'where it's used' can be ignored here, this is supposed to be a startup time optimization (to avoid blender's python to import everything when starting Blender), but in practice doubt this is giving any real improvements here, since numpy is also imported in fbx_utils etc.

Patch look good. Also think that the `import`s 'where it's used' can be ignored here, this is supposed to be a startup time optimization (to avoid blender's python to import everything when starting Blender), but in practice doubt this is giving any real improvements here, since numpy is also imported in `fbx_utils` etc.
Thomas Barlow force-pushed fbx_import_cycles_workaround_np_pr from 7a4e3a5da8 to e5e3363514 2023-03-22 05:37:09 +01:00 Compare
Thomas Barlow commented 2023-03-22 07:11:22 +01:00
Author
Member
Copy Link

The imports and shared parray_as_ndarray utility function have been moved to a separate commit that has its own PR: #104499

The imports and shared `parray_as_ndarray` utility function have been moved to a separate commit that has its own PR: https://projects.blender.org/blender/blender-addons/issues/104499
Thomas Barlow requested review from Bastien Montagne 2023-03-22 07:11:28 +01:00
Bastien Montagne force-pushed fbx_import_cycles_workaround_np_pr from e5e3363514 to 5da3d41c27 2023-04-03 14:41:49 +02:00 Compare
Bastien Montagne approved these changes 2023-04-03 14:42:36 +02:00
Bastien Montagne merged commit 5da3d41c27 into main 2023-04-03 14:43:06 +02:00
Bastien Montagne deleted branch fbx_import_cycles_workaround_np_pr 2023-04-03 14:43:06 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Bastien Montagne
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#104497
No description provided.
Delete Branch "Mysteryem/blender-addons:fbx_import_cycles_workaround_np_pr"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?