blender/blender-addons
19
43
Fork 96
Code Issues 627 Pull Requests 27 Projects 1 Releases Wiki Activity

FBX import/export: Fix Camera rotation #104500

Open
Inho Lee wants to merge 1 commits from Inho-Lee/blender-addons:main into main
pull from: Inho-Lee/blender-addons:main
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 7 Commits 1 Files Changed 3 +7 -5
Inho Lee commented 2023-03-22 08:28:48 +01:00
First-time contributor
Copy Link

FBX-Blender axis correction should not be applied
for cameras' Position, UpVector and InterestPosition

Fixes #45176

FBX-Blender axis correction should not be applied for cameras' Position, UpVector and InterestPosition Fixes #45176
Bastien Montagne commented 2023-04-12 11:50:52 +02:00
Owner
Copy Link

Am missing a bit of context/explanation about why this fix would be the proper solution here? Would also be good to know if this was successfully tested at least against the major game engines (Unity, Unreal...)?

Another question is, does this survive camera animation?

Camera fixes have a notorious history of 'fixing one issue with one third party software, creating another issue with another third party tool' ;)

@Mysteryem may know better though here?

Am missing a bit of context/explanation about why this fix would be the proper solution here? Would also be good to know if this was successfully tested at least against the major game engines (Unity, Unreal...)? Another question is, does this survive camera animation? Camera fixes have a notorious history of 'fixing one issue with one third party software, creating another issue with another third party tool' ;) @Mysteryem may know better though here?
Bastien Montagne reviewed 2023-04-12 11:51:04 +02:00
io_scene_fbx/fbx_utils.py
@ -57,6 +57,7 @@ FBX_KTIME = 46186158000 # This is the number of "ktimes" in one second (yep, pr
MAT_CONVERT_LIGHT = Matrix.Rotation(math.pi / 2.0, 4, 'X') # Blender is -Z, FBX is -Y.
MAT_CONVERT_CAMERA = Matrix.Rotation(math.pi / 2.0, 4, 'Y') # Blender is -Z, FBX is +X.
Bastien Montagne commented 2023-04-12 11:47:22 +02:00
Owner
Copy Link

Would rename this to MAT_CONVERT_CAMERA_IMPORT

Would rename this to `MAT_CONVERT_CAMERA_IMPORT`
io_scene_fbx/fbx_utils.py Outdated
@ -57,6 +57,7 @@ FBX_KTIME = 46186158000 # This is the number of "ktimes" in one second (yep, pr
MAT_CONVERT_LIGHT = Matrix.Rotation(math.pi / 2.0, 4, 'X') # Blender is -Z, FBX is -Y.
MAT_CONVERT_CAMERA = Matrix.Rotation(math.pi / 2.0, 4, 'Y') # Blender is -Z, FBX is +X.
MAT_CONVERT_CAMERA_INVERSE = Matrix.Rotation(-math.pi / 2.0, 4, 'Y')
Bastien Montagne commented 2023-04-12 11:47:35 +02:00
Owner
Copy Link

Would rename this to MAT_CONVERT_CAMERA_EXPORT

Would rename this to `MAT_CONVERT_CAMERA_EXPORT`
Inho Lee commented 2023-04-12 13:49:37 +02:00
Author
First-time contributor
Copy Link

I'm not sure MAT_CONVERT_CAMERA_EXPORT is a proper name here. MAT_CONVERT_CAMERA is need for export operations too. However this inverse matrix is required in order to property calculate special properties UpVector, InterestPosition.

I'm not sure MAT_CONVERT_CAMERA_EXPORT is a proper name here. MAT_CONVERT_CAMERA is need for export operations too. However this inverse matrix is required in order to property calculate special properties UpVector, InterestPosition.
Inho Lee commented 2023-04-12 13:41:57 +02:00
Author
First-time contributor
Copy Link

Originally I tested FBX cameras in QtQuick3D. At the first time, I exported a blender scene into a FBX format and read it through libassimp.
Recently I found a bug in libassimp which assumed the camera properties as default values and fixed it.(cdfdd75a66) This patch is related with it.

I tested it with FBXSDK while exporting blender scenes having a camera to FBXs.
Do you have any example fbx files for more tests?

I didn't consider any import cases.

Originally I tested FBX cameras in QtQuick3D. At the first time, I exported a blender scene into a FBX format and read it through libassimp. Recently I found a bug in libassimp which assumed the camera properties as default values and fixed it.(https://github.com/assimp/assimp/commit/cdfdd75a66e2323bd834f923798d3043ad3deaf8) This patch is related with it. I tested it with FBXSDK while exporting blender scenes having a camera to FBXs. Do you have any example fbx files for more tests? I didn't consider any import cases.
Jesse Yurkovich commented 2023-04-13 09:10:49 +02:00
Member
Copy Link

Issue #45176 is about Import, so it would not be correct to say that this fixes that issue in your description.

Issue #45176 is about Import, so it would not be correct to say that this fixes that issue in your description.
Inho Lee force-pushed main from d995d8c634 to 29b8d4967e 2023-04-14 12:27:40 +02:00 Compare
Inho Lee force-pushed main from 29b8d4967e to f30518faf8 2023-04-14 12:28:54 +02:00 Compare
Inho Lee changed title from FBX export: Fix Camera rotation to FBX import/export: Fix Camera rotation 2023-04-14 12:31:55 +02:00
Inho Lee commented 2023-04-14 12:33:02 +02:00
Author
First-time contributor
Copy Link

I tested import feature and the fbx files in Issue #45176

I tested import feature and the fbx files in Issue #45176
Thomas Barlow commented 2023-04-18 02:26:16 +02:00
Member
Copy Link

With the import patch, importing an FBX exported by Blender (default settings for both import and export) (both with and without the export patches in this PR) results in the camera being inverted for me.
For example, Blender's default startup scene exported as FBX and re-imported:
image

The export patch changes the "Up", "To", "UpVector" and "InterestPosition" properties, but as far as I can tell, the FBX importer doesn't read any of those properties in the first place.

With the import patch, importing an FBX exported by Blender (default settings for both import and export) (both with and without the export patches in this PR) results in the camera being inverted for me. For example, Blender's default startup scene exported as FBX and re-imported: ![image](/attachments/573b25b2-512d-4c30-97f4-03a1bd6e86b8) The export patch changes the `"Up"`, `"To"`, `"UpVector"` and `"InterestPosition"` properties, but as far as I can tell, the FBX importer doesn't read any of those properties in the first place.
image.png
107 KiB
Inho Lee commented 2023-04-18 07:00:11 +02:00
Author
First-time contributor
Copy Link

With the import patch, importing an FBX exported by Blender (default settings for both import and export) (both with and without the export patches in this PR) results in the camera being inverted for me.
For example, Blender's default startup scene exported as FBX and re-imported:
image

The export patch changes the "Up", "To", "UpVector" and "InterestPosition" properties, but as far as I can tell, the FBX importer doesn't read any of those properties in the first place.

Oh Thanks. Now I could understand fully. I'll upload the patch in this weekend.

> With the import patch, importing an FBX exported by Blender (default settings for both import and export) (both with and without the export patches in this PR) results in the camera being inverted for me. > For example, Blender's default startup scene exported as FBX and re-imported: > ![image](/attachments/573b25b2-512d-4c30-97f4-03a1bd6e86b8) > > The export patch changes the `"Up"`, `"To"`, `"UpVector"` and `"InterestPosition"` properties, but as far as I can tell, the FBX importer doesn't read any of those properties in the first place. Oh Thanks. Now I could understand fully. I'll upload the patch in this weekend.
Thomas Barlow commented 2023-04-20 05:14:12 +02:00
Member
Copy Link

Since this PR was originally only affecting exports, I've tried to find and fix the import issue with #104561

Since this PR was originally only affecting exports, I've tried to find and fix the import issue with https://projects.blender.org/blender/blender-addons/pulls/104561
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u main:Inho-Lee-main
git checkout Inho-Lee-main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#104500
No description provided.
Delete Branch "Inho-Lee/blender-addons:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?