blender/blender-addons
19
43
Fork 96
Code Issues 627 Pull Requests 27 Projects 1 Releases Wiki Activity

object_collection_manager: replace deprecated bgl module #104547

Closed
Oxicid wants to merge 4 commits from (deleted):oxicid-cm-bgl into main
pull from: (deleted):oxicid-cm-bgl
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 2 Commits 4 Files Changed 3 +15 -25
Oxicid commented 2023-04-15 15:42:28 +02:00
Contributor
Copy Link

No response

_No response_
Oxicid added 3 commits 2023-04-15 15:42:30 +02:00
Oxicid requested review from Germano Cavalcante 2023-04-15 15:42:55 +02:00
Oxicid commented 2023-04-15 15:49:11 +02:00
Author
Contributor
Copy Link

In this addon bgl was used in 3 cases, in the other 4 I did not understand how and where it was used

In this addon bgl was used in 3 cases, in the other 4 I did not understand how and where it was used
Ryan Inch requested changes 2023-04-16 11:00:28 +02:00
Ryan Inch left a comment
Member
Copy Link

Hi, I'm the creator and maintainer of the Collection Manager add-on, so I'll be reviewing your PR :)

I'm not exactly sure what you're referring to by "No response". If you're referring to the conversation in #80730 then it turned out that bgl was not getting removed in 3.4.

I'm also not sure what you mean by the other 4. Can you clarify?

Aside from one comment I left in the code, this seems good to me, so thanks for the PR.

Hi, I'm the creator and maintainer of the Collection Manager add-on, so I'll be reviewing your PR :) I'm not exactly sure what you're referring to by "No response". If you're referring to the conversation in https://projects.blender.org/blender/blender-addons/issues/80730 then it turned out that bgl was not getting removed in 3.4. I'm also not sure what you mean by the other 4. Can you clarify? Aside from one comment I left in the code, this seems good to me, so thanks for the PR.
object_collection_manager/__init__.py Outdated
@ -9,2 +9,2 @@
"version": (2, 24, 4),
"blender": (2, 80, 0),
"version": (2, 24, 5),
"blender": (3, 4, 0),
Ryan Inch commented 2023-04-16 10:58:39 +02:00
Member
Copy Link

I like to keep this to the minimum version of Blender the add-on will work with, which from my tests just now on Linux seems to be 2.93. So unless this is different on other platforms could you please set it to 2.93?

I like to keep this to the minimum version of Blender the add-on will work with, which from my tests just now on Linux seems to be 2.93. So unless this is different on other platforms could you please set it to 2.93?
Oxicid commented 2023-04-16 11:36:05 +02:00
Author
Contributor
Copy Link

I looked more closely, everything is involved.
About the minimum version, I just do not know which version introduced new methods for gpu module, and decided to set it to 3.4 for sure. To be sure I checked with 2.93, everything works

I looked more closely, everything is involved. About the minimum version, I just do not know which version introduced new methods for gpu module, and decided to set it to 3.4 for sure. To be sure I checked with 2.93, everything works
Ryan Inch commented 2023-04-16 11:39:23 +02:00
Member
Copy Link

Ah, okay. Makes sense. Thanks for changing it and the additional checking.

Ah, okay. Makes sense. Thanks for changing it and the additional checking.
Imaginer marked this conversation as resolved
Oxicid added 1 commit 2023-04-16 11:09:10 +02:00
Oxicid requested review from Ryan Inch 2023-04-16 11:36:14 +02:00
Ryan Inch approved these changes 2023-04-16 11:48:43 +02:00
Ryan Inch left a comment
Member
Copy Link

LGTM. Thanks.

LGTM. Thanks.
Ryan Inch commented 2023-04-16 12:22:02 +02:00
Member
Copy Link

I'll hold off on merging this until after the weekend so @mano-wii has a chance to respond if they want.

I'll hold off on merging this until after the weekend so @mano-wii has a chance to respond if they want.
Germano Cavalcante reviewed 2023-04-17 19:38:50 +02:00
Germano Cavalcante requested changes 2023-04-17 19:39:53 +02:00
Germano Cavalcante left a comment
Member
Copy Link

Thanks for the patch but line_width_set doesn't work on MACOS and will surely be deprecated.

Use the 'POLYLINE_SMOOTH_COLOR' shader instead. (The 3D_ or 2D_ prefixes make no difference and were kept only for backward compatibility).

You can check examples in #80730. One that might help is the node_wrangler.py (d37c2abc6f) one.

Thanks for the patch but `line_width_set` doesn't work on MACOS and will surely be deprecated. Use the `'POLYLINE_SMOOTH_COLOR'` shader instead. (The `3D_` or `2D_` prefixes make no difference and were kept only for backward compatibility). You can check examples in #80730. One that might help is the node_wrangler.py (d37c2abc6f) one.
object_collection_manager/qcd_move_widget.py
@ -100,3 +99,1 @@
bgl.glLineWidth(thickness)
bgl.glEnable(bgl.GL_LINE_SMOOTH)
bgl.glHint(bgl.GL_LINE_SMOOTH_HINT, bgl.GL_NICEST)
gpu.state.line_width_set(thickness)
Germano Cavalcante commented 2023-04-17 19:39:47 +02:00
Member
Copy Link

line_width_set should no longer be used.

`line_width_set` should no longer be used.
Oxicid closed this pull request 2023-04-18 19:34:05 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Ryan Inch
Germano Cavalcante
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#104547
No description provided.
Delete Branch "(deleted):oxicid-cm-bgl"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?