VDM brush baker #104580

Merged
Joseph Eagar merged 10 commits from robin.hohni/blender-addons:vdm-brush-baker into main 2023-05-12 15:42:12 +02:00
Contributor

An add-on that simplifies the creation of vector displacement brushes in Blender.

The add-on panel can be found in the tool panel.
'Create sculpting plane' will create a grid with two multires subdivisions applied. It can be used to sculpt the vector displacement.
'Render and create brush' will as the name implies create VDM from the sculpting plane plus a sculpting brush that uses the VDM.
The material that is needed for baking VDMs is created via code.

An add-on that simplifies the creation of vector displacement brushes in Blender. The add-on panel can be found in the tool panel. 'Create sculpting plane' will create a grid with two multires subdivisions applied. It can be used to sculpt the vector displacement. 'Render and create brush' will as the name implies create VDM from the sculpting plane plus a sculpting brush that uses the VDM. The material that is needed for baking VDMs is created via code.
Robin Hohnsbeen added 3 commits 2023-04-29 12:54:00 +02:00
Robin Hohnsbeen added 1 commit 2023-04-29 13:00:33 +02:00

Is the plan here to ship the VDM addon with Blender instead of relying on the demo download? (https://www.blender.org/download/demo-files/#sculpting)

If so, can you take a look and see if the following 2 bugs are fixed:
blender/blender#106785
blender/blender#106472

From a quick glance it seems like they would be fixed.

Is the plan here to ship the VDM addon with Blender instead of relying on the demo download? (https://www.blender.org/download/demo-files/#sculpting) If so, can you take a look and see if the following 2 bugs are fixed: https://projects.blender.org/blender/blender/issues/106785 https://projects.blender.org/blender/blender/issues/106472 From a quick glance it seems like they would be fixed.
Author
Contributor

@deadpin yes, that's the plan. And these two issues are fixed. 👍

@deadpin yes, that's the plan. And these two issues are fixed. 👍
Julien Kaspar added the
Interest
Sculpt, Paint & Texture
label 2023-05-01 10:41:10 +02:00
Julien Kaspar requested review from Joseph Eagar 2023-05-01 11:20:04 +02:00
Julien Kaspar requested review from Julien Kaspar 2023-05-01 11:20:04 +02:00
Robin Hohnsbeen added 2 commits 2023-05-01 11:59:21 +02:00
Julien Kaspar approved these changes 2023-05-08 11:25:23 +02:00
Julien Kaspar left a comment
Member

As far as I've tested it, it works wonderfully. We should get this in for the 3.6 release.

As far as I've tested it, it works wonderfully. We should get this in for the 3.6 release.
Julien Kaspar requested changes 2023-05-08 11:32:44 +02:00
Julien Kaspar left a comment
Member

Actually there were some changes that @pablovazquez did for the demo file.

  • The text could use proper capitalization.
  • The name field should be red if the name is already taken
  • The button can then read "Overwrite VDM Brush"

image

image

Actually there were some changes that @pablovazquez did for the demo file. - The text could use proper capitalization. - The name field should be red if the name is already taken - The button can then read "Overwrite VDM Brush" ![image](/attachments/d215165b-4673-4112-8002-23f4eaab98e7) ![image](/attachments/8e57befa-76c1-4d78-b2f8-d0d7937ea313)
Robin Hohnsbeen added 1 commit 2023-05-08 19:32:38 +02:00
Author
Contributor

Didn't know Pablo improved my UI ^^

Applied his improvements 👍

Didn't know Pablo improved my UI ^^ Applied his improvements 👍
Member

Great! Only things I still notice are that when using the "Render and Create VDM Brush" button, it will reset the transforms of the plane and end up in sculpt mode.
Perhaps that can be prevented, so it keeps the transforms and edns up in the same mode?

Otherwise this looks all good to me.

Great! Only things I still notice are that when using the "Render and Create VDM Brush" button, it will reset the transforms of the plane and end up in sculpt mode. Perhaps that can be prevented, so it keeps the transforms and edns up in the same mode? Otherwise this looks all good to me.
Member

@mont29 If ready before Bcon4, we'd like to still merge this for Blender 3.6.
Would you have anything to point out for this PR?

@mont29 If ready before Bcon4, we'd like to still merge this for Blender 3.6. Would you have anything to point out for this PR?
Bastien Montagne approved these changes 2023-05-12 12:18:18 +02:00
Bastien Montagne left a comment
Owner

Mainly remarks on formatting, and the license presentation.

Do not have time for a proper full code review, but from a very quick overview saw nothing bad, so if UI/UX department is fine with it (i.e. tool has been tested and works as expected and has good UI), think it's fine to move it to main.

Mainly remarks on formatting, and the license presentation. Do not have time for a proper full code review, but from a very quick overview saw nothing bad, so if UI/UX department is fine with it (i.e. tool has been tested and works as expected and has good UI), think it's fine to move it to main.
@ -0,0 +13,4 @@
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
'''

Nowadays we recommend using the SPDX license header instead, it's a widely accepted, one line license 'place holder', see also https://spdx.org/licenses/

GPLv3 or later would be:

# SPDX-License-Identifier: GPL-3.0-or-later

Plus the copyright line.

Nowadays we recommend using the SPDX license header instead, it's a widely accepted, one line license 'place holder', see also https://spdx.org/licenses/ GPLv3 or later would be: ```# SPDX-License-Identifier: GPL-3.0-or-later``` Plus the copyright line.
robin.hohni marked this conversation as resolved
@ -0,0 +351,4 @@
for registered_class in registered_classes:
bpy.utils.unregister_class(registered_class)
del bpy.types.Scene.VDMBrushBakerAddonData

Missing empty line at the end

Missing empty line at the end
@ -0,0 +1,63 @@
import bpy

Missing license header (either 'regular' one or the SPDX one)

Missing license header (either 'regular' one or the SPDX one)
@ -0,0 +60,4 @@
tree.links.new(tex_coord_node.outputs[3], separate_node2.inputs[0])
tree.links.new(separate_node2.outputs[2], combine_node.inputs[2])
return bpy.data.materials[material_name]

Missing empty line at the end

Missing empty line at the end
Author
Contributor

My local files do have an empty line at the end. I'm not sure why it doesn't show up in gitea 🤔

My local files do have an empty line at the end. I'm not sure why it doesn't show up in gitea 🤔
Robin Hohnsbeen added 3 commits 2023-05-12 13:30:08 +02:00
Robin Hohnsbeen requested review from Julien Kaspar 2023-05-12 13:34:02 +02:00
Julien Kaspar approved these changes 2023-05-12 15:25:58 +02:00
Julien Kaspar left a comment
Member

All issues are resolved afaics 👍

All issues are resolved afaics :+1:
Joseph Eagar merged commit 556f0fa0d9 into main 2023-05-12 15:42:12 +02:00
Joseph Eagar referenced this issue from a commit 2023-05-12 15:42:12 +02:00
Dalai Felinto referenced this issue from a commit 2024-05-11 03:22:43 +02:00
Dalai Felinto referenced this issue from a commit 2024-05-14 11:01:51 +02:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#104580
No description provided.