VDM brush baker #104580
No reviewers
Labels
No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender-addons#104580
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "robin.hohni/blender-addons:vdm-brush-baker"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
An add-on that simplifies the creation of vector displacement brushes in Blender.
The add-on panel can be found in the tool panel.
'Create sculpting plane' will create a grid with two multires subdivisions applied. It can be used to sculpt the vector displacement.
'Render and create brush' will as the name implies create VDM from the sculpting plane plus a sculpting brush that uses the VDM.
The material that is needed for baking VDMs is created via code.
Is the plan here to ship the VDM addon with Blender instead of relying on the demo download? (https://www.blender.org/download/demo-files/#sculpting)
If so, can you take a look and see if the following 2 bugs are fixed:
blender/blender#106785
blender/blender#106472
From a quick glance it seems like they would be fixed.
@deadpin yes, that's the plan. And these two issues are fixed. 👍
As far as I've tested it, it works wonderfully. We should get this in for the 3.6 release.
Actually there were some changes that @pablovazquez did for the demo file.
Didn't know Pablo improved my UI ^^
Applied his improvements 👍
Great! Only things I still notice are that when using the "Render and Create VDM Brush" button, it will reset the transforms of the plane and end up in sculpt mode.
Perhaps that can be prevented, so it keeps the transforms and edns up in the same mode?
Otherwise this looks all good to me.
@mont29 If ready before Bcon4, we'd like to still merge this for Blender 3.6.
Would you have anything to point out for this PR?
Mainly remarks on formatting, and the license presentation.
Do not have time for a proper full code review, but from a very quick overview saw nothing bad, so if UI/UX department is fine with it (i.e. tool has been tested and works as expected and has good UI), think it's fine to move it to main.
@ -0,0 +13,4 @@
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
'''
Nowadays we recommend using the SPDX license header instead, it's a widely accepted, one line license 'place holder', see also https://spdx.org/licenses/
GPLv3 or later would be:
# SPDX-License-Identifier: GPL-3.0-or-later
Plus the copyright line.
@ -0,0 +351,4 @@
for registered_class in registered_classes:
bpy.utils.unregister_class(registered_class)
del bpy.types.Scene.VDMBrushBakerAddonData
Missing empty line at the end
@ -0,0 +1,63 @@
import bpy
Missing license header (either 'regular' one or the SPDX one)
@ -0,0 +60,4 @@
tree.links.new(tex_coord_node.outputs[3], separate_node2.inputs[0])
tree.links.new(separate_node2.outputs[2], combine_node.inputs[2])
return bpy.data.materials[material_name]
Missing empty line at the end
My local files do have an empty line at the end. I'm not sure why it doesn't show up in gitea 🤔
All issues are resolved afaics 👍