Rigify: add a warning if feature set requires newer Blender version #104631

Damien Picard · 2023-05-23T18:01:49+02:00

Damien Picard commented

2023-05-23 18:01:49 +02:00

Users often install a Rigify feature set that was created for a newer
version of Blender. This is the source of frustration and bug reports.

This commit adds a basic warning to the feature set panel if the
active feature set was meant to be used with a newer Blender version.

Alleviates #97622.

Users often install a Rigify feature set that was created for a newer version of Blender. This is the source of frustration and bug reports. This commit adds a basic warning to the feature set panel if the active feature set was meant to be used with a newer Blender version. Alleviates #97622. --- ![Screenshot_20230523_180012.png](/attachments/da50302a-3f0a-4853-bbdc-3b5188418865)

Screenshot_20230523_180012.png

45 KiB

Damien Picard requested review from Demeter Dzadik 2023-05-23 18:02:00 +02:00

Damien Picard changed target branch from main to blender-v3.6-release

2023-05-23 18:04:26 +02:00

Demeter Dzadik commented

2023-05-24 03:11:44 +02:00

While I think this is a good idea and have nothing against it and it will help, I just want to point out that there's also the case where the minimum Blender version requirement might be met, but changes to Blender or Rigify might make things look weird, or possibly even break things.

For example, when the Action system was moved from CloudRig to Rigify. If a version of CloudRig is used from before that change, in a version of Blender from after that change, the minimum version requirement is met, but there will be two Actions panels, one from CloudRig, and one from Rigify. And to be honest, I don't know if that will break or not, but it sure isn't intended to work.

So, this patch won't fix 100% of the issues that are resulting in confused CloudRig users creating bug reports, but it's still better than nothing and I think it's a good addition.

No idea how to approve patches on Gitea, but also, I don't really consider myself a Rigify maintainer who should be approving patches, I'd leave that to @angavrilov.

While I think this is a good idea and have nothing against it and it will help, I just want to point out that there's also the case where the minimum Blender version requirement might be met, but changes to Blender or Rigify might make things look weird, or possibly even break things. For example, when the Action system was moved from CloudRig to Rigify. If a version of CloudRig is used from before that change, in a version of Blender from after that change, the minimum version requirement is met, but there will be two Actions panels, one from CloudRig, and one from Rigify. And to be honest, I don't know if that will break or not, but it sure isn't intended to work. So, this patch won't fix 100% of the issues that are resulting in confused CloudRig users creating bug reports, but it's still better than nothing and I think it's a good addition. No idea how to approve patches on Gitea, but also, I don't really consider myself a Rigify maintainer who should be approving patches, I'd leave that to @angavrilov.

Damien Picard commented

2023-05-24 11:20:32 +02:00

So, this patch won't fix 100% of the issues that are resulting in confused CloudRig users creating bug reports

Right, no warning is enough for that :D But I figure it’s better than nothing, and since you define the blender version in CloudRig, might as well use it.

> So, this patch won't fix 100% of the issues that are resulting in confused CloudRig users creating bug reports Right, no warning is enough for that :D But I figure it’s better than nothing, and since you define the `blender` version in CloudRig, might as well use it.

Damien Picard requested review from Alexander Gavrilov 2023-05-24 11:20:47 +02:00

Pratik Borhade referenced this pull request from blender/blender

2023-06-08 10:58:36 +02:00

Rigify Addon Enable #108739

Damien Picard changed title from ~~Rigify: add a warning if feature set requires newer Blender version~~ to Rigify: add a warning if feature set requires newer Blender version

2023-06-23 10:07:23 +02:00

Damien Picard changed target branch from blender-v3.6-release to main

2023-06-23 10:07:24 +02:00

Pratik Borhade referenced this pull request

2023-07-11 12:10:54 +02:00

Add-On Rigging Rigify doesn't work in Blender 3.3 LTS #104746

Damien Picard commented

2023-07-31 03:54:13 +02:00

@angavrilov Hi, are you interested in reviewing this? If not, any opposition to me merging it?

Damien Picard force-pushed dp_rigify_feature_set_warning from e90f96ada6 to acdd4b804b

2023-09-03 18:37:20 +02:00

Compare

Damien Picard merged commit b70da04b92 into main

2023-09-03 18:38:59 +02:00

Damien Picard deleted branch dp_rigify_feature_set_warning

2023-09-03 18:38:59 +02:00

Damien Picard referenced this issue from a commit

2023-09-03 18:39:00 +02:00

Rigify: add a warning if feature set requires newer Blender version

Demeter Dzadik commented

2023-09-04 18:23:34 +02:00

Actually now that you ping, I think you're trying to do something clever in the warning message by incrementing the version number to get a nice sounding sentence for the user, but Blender 3.7 isn't a valid version number, hehe.
But other than that, I also hope this can make it in.

Actually now that you ping, I think you're trying to do something clever in the warning message by incrementing the version number to get a nice sounding sentence for the user, but Blender 3.7 isn't a valid version number, hehe. But other than that, I also hope this can make it in.

Damien Picard commented

2023-09-04 18:44:24 +02:00

I think you're trying to do something clever in the warning message by incrementing the version number

Oh no actually I just manually incremented the minimum version in your feature set to test that the error appeared! Maybe I should have chosen 4.0 :D

I also hope this can make it in.

I took the liberty to merge it myself, I will revert if anything wrong comes up.

> I think you're trying to do something clever in the warning message by incrementing the version number Oh no actually I just manually incremented the minimum version in your feature set to test that the error appeared! Maybe I should have chosen 4.0 :D > I also hope this can make it in. I took the liberty to merge it myself, I will revert if anything wrong comes up.

Sign in to join this conversation.

No reviewers