blender/blender-addons
19
44
Fork 96
Code Issues 632 Pull Requests 27 Projects 1 Releases Wiki Activity

FBX IO: Edge/face sharp access with attributes #104649

Merged
Bastien Montagne merged 1 commits from Mysteryem/blender-addons:attribute_access_sharp_smooth_pr into main 2023-06-26 15:46:41 +02:00
Conversation 1 Commits 1 Files Changed 2 +58 -46
Thomas Barlow commented 2023-05-29 05:12:24 +02:00
Member
Copy Link

Blender 3.5 moved edge sharp to a generic attribute and 3.6 moved face
smooth to a generic attribute. The old API still works for now, but is
slower and may be removed in 4.0, so this patch updates FBX IO to use
the new "sharp_edge" and "sharp_face" attributes.

Because the old API was face smooth, not sharp, the logic for working
with "sharp_face" is inverted compared to before.

When the "sharp_edge" or "sharp_face" attributes do not exist, all edges
or faces can be assumed to not be marked sharp, reducing necessary work.

A comment comparing the speed of calculating polygon sides from t_ls
vs getting polygon sides from polygon "loop_total" has been updated to
reflect the change that "loop_total" is not stored internally as of 3.6
and is now slower to access.

This patch makes a minor change to the import of FBX files, whereby code
that used to set every face to smooth now removes the "sharp_face"
attribute instead.

Blender 3.5 moved edge sharp to a generic attribute and 3.6 moved face smooth to a generic attribute. The old API still works for now, but is slower and may be removed in 4.0, so this patch updates FBX IO to use the new "sharp_edge" and "sharp_face" attributes. Because the old API was face smooth, not sharp, the logic for working with "sharp_face" is inverted compared to before. When the "sharp_edge" or "sharp_face" attributes do not exist, all edges or faces can be assumed to not be marked sharp, reducing necessary work. A comment comparing the speed of calculating polygon sides from `t_ls` vs getting polygon sides from polygon "loop_total" has been updated to reflect the change that "loop_total" is not stored internally as of 3.6 and is now slower to access. This patch makes a minor change to the import of FBX files, whereby code that used to set every face to smooth now removes the "sharp_face" attribute instead.
Thomas Barlow commented 2023-05-29 05:42:33 +02:00
Author
Member
Copy Link

This PR depends on the base patch for adding attribute utility functions: #104645

This PR depends on the base patch for adding attribute utility functions: https://projects.blender.org/blender/blender-addons/pulls/104645
Thomas Barlow requested review from Bastien Montagne 2023-05-29 05:45:41 +02:00
Thomas Barlow force-pushed attribute_access_sharp_smooth_pr from d8c9d1b668 to 8f03ef8302 2023-06-26 04:59:11 +02:00 Compare
Bastien Montagne force-pushed attribute_access_sharp_smooth_pr from 8f03ef8302 to 2a58d659aa 2023-06-26 15:31:34 +02:00 Compare
Bastien Montagne approved these changes 2023-06-26 15:46:29 +02:00
Bastien Montagne merged commit eb2bfdcaf1 into main 2023-06-26 15:46:41 +02:00
Bastien Montagne deleted branch attribute_access_sharp_smooth_pr 2023-06-26 15:46:42 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Bastien Montagne
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#104649
No description provided.
Delete Branch "Mysteryem/blender-addons:attribute_access_sharp_smooth_pr"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?