blender/blender-addons
18
42
Fork 95
Code Issues 616 Pull Requests 29 Projects 1 Releases Wiki Activity

Rigify - saving pbone custom properties to metarig #104695

Merged
Alexander Gavrilov merged 6 commits from Andrej730/blender-addons:rigify_custom_props into main 2023-09-25 21:52:59 +02:00
Conversation 1 Commits 6 Files Changed 1 +37
Andrej commented 2023-06-15 11:00:35 +02:00
Contributor
Copy Link

Added support for some pbone custom properties saving to metarig.
Custom properties widely used as a way to tweak rigs with drivers - so an option to save them to metarig will definitely help.

PS Accidentally removed the branch for #104414 so recreating PR

Added support for some pbone custom properties saving to metarig. Custom properties widely used as a way to tweak rigs with drivers - so an option to save them to metarig will definitely help. PS Accidentally removed the branch for #104414 so recreating PR
Andrej added 1 commit 2023-06-15 11:00:38 +02:00
Andrej requested review from Alexander Gavrilov 2023-06-15 11:01:34 +02:00
Pratik Borhade commented 2023-07-27 11:13:20 +02:00
Member
Copy Link

@angavrilov hi, could you review this PR? :)

@angavrilov hi, could you review this PR? :)
Alexander Gavrilov requested changes 2023-09-05 12:43:46 +02:00
rigify/utils/rig.py Outdated
@ -414,1 +415,4 @@
# Custom properties
custom_properties = [
custom_property for custom_property in pbone.keys()
Alexander Gavrilov commented 2023-09-05 12:41:47 +02:00
Member
Copy Link

Iterate over items() to get both key and value.

Iterate over `items()` to get both key and value.
Andrej commented 2023-09-09 18:59:46 +02:00
Author
Contributor
Copy Link

resolved in 3677cc4549

resolved in 3677cc454907e82731ac2360be5846d988e48e8c
rigify/utils/rig.py Outdated
@ -415,0 +428,4 @@
code.append(f" rna_idprop_ui_create(")
code.append(f" pbone, ")
code.append(f" '{custom_property}', ")
code.append(f" default={props_data['default']}, ")
Alexander Gavrilov commented 2023-09-05 12:42:58 +02:00
Member
Copy Link

What if the default isn't equal to the current value? This code doesn't preserve the value anywhere.

What if the default isn't equal to the current value? This code doesn't preserve the value anywhere.
Andrej commented 2023-09-09 19:00:05 +02:00
Author
Contributor
Copy Link

resolved in 3677cc4549

resolved in 3677cc454907e82731ac2360be5846d988e48e8c
Alexander Gavrilov commented 2023-09-25 12:18:35 +02:00
Member
Copy Link

I'd quote default with repr too. Also, get rid of trailing spaces.

I'd quote default with repr too. Also, get rid of trailing spaces.
Andrej commented 2023-09-25 19:44:06 +02:00
Author
Contributor
Copy Link

resolved in 076763507e

resolved in 076763507e82ff209f546aba4b2ab03061254d9d
rigify/utils/rig.py Outdated
@ -415,0 +438,4 @@
if 'soft_max' in props_data:
code.append(f" soft_max={props_data['soft_max']}, ")
if 'description' in props_data:
code.append(f" description='{props_data['description']}'")
Alexander Gavrilov commented 2023-09-05 12:40:57 +02:00
Member
Copy Link

Rather than doing '{foo}', use {repr(foo)}. Manual quoting could be barely tolerated for property names, but for the description it is simply unacceptable.

Rather than doing `'{foo}'`, use `{repr(foo)}`. Manual quoting could be barely tolerated for property names, but for the description it is simply unacceptable.
Andrej commented 2023-09-09 19:01:15 +02:00
Author
Contributor
Copy Link

that's really neat thing about repr, didn't know it can be used that way!
resolved in e2b63e1a4b

that's really neat thing about `repr`, didn't know it can be used that way! resolved in e2b63e1a4b07ffa8ca59eef5b4b2be17189f49ff
Andrej added 3 commits 2023-09-09 18:58:54 +02:00
Andrej requested review from Alexander Gavrilov 2023-09-09 19:01:24 +02:00
Alexander Gavrilov requested changes 2023-09-25 12:21:19 +02:00
rigify/utils/rig.py Outdated
@ -415,0 +443,4 @@
code.append(f" description={props_data['description']!r}")
code.append(f" )")
if 'precision' in props_data:
code.append(f" pbone.id_properties_ui('{custom_property}').update(precision={props_data['precision']})")
Alexander Gavrilov commented 2023-09-25 12:19:52 +02:00
Member
Copy Link

This is still not using repr. Also, step and precision should now be supported directly by rna_idprop_ui_create, I fixed that recently.

This is still not using repr. Also, step and precision should now be supported directly by `rna_idprop_ui_create`, I fixed that recently.
Andrej commented 2023-09-25 19:59:55 +02:00
Author
Contributor
Copy Link

Resolved in ca78100418

Resolved in ca78100418069ed45b340504ffcb55a03327627e
rigify/utils/rig.py Outdated
@ -415,0 +444,4 @@
code.append(f" )")
if 'precision' in props_data:
code.append(f" pbone.id_properties_ui('{custom_property}').update(precision={props_data['precision']})")
code.append(f" pbone[{custom_property!r}] = {current_value}")
Alexander Gavrilov commented 2023-09-25 12:20:28 +02:00
Member
Copy Link

If current_value is actually equal to default, this would be redundant.

If current_value is actually equal to default, this would be redundant.
Andrej commented 2023-09-25 19:44:35 +02:00
Author
Contributor
Copy Link

resolved in 076763507e

resolved in 076763507e82ff209f546aba4b2ab03061254d9d
Andrej added 1 commit 2023-09-25 19:38:47 +02:00 
Fixed:
- trailing spaces
- repr for default value
- don't set current value if it's the same as default
Andrej added 1 commit 2023-09-25 19:56:02 +02:00
Andrej requested review from Alexander Gavrilov 2023-09-25 20:00:04 +02:00
Alexander Gavrilov approved these changes 2023-09-25 21:50:59 +02:00
Alexander Gavrilov merged commit c9c0744ff7 into main 2023-09-25 21:52:59 +02:00
Andrej deleted branch rigify_custom_props 2023-09-25 22:16:26 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Alexander Gavrilov
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#104695
No description provided.
Delete Branch "Andrej730/blender-addons:rigify_custom_props"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?