blender/blender-addons
19
44
Fork 96
Code Issues 634 Pull Requests 28 Projects 1 Releases Wiki Activity

Rigify - saving pbone custom properties to metarig #104695

Merged
Alexander Gavrilov merged 6 commits from Andrej730/blender-addons:rigify_custom_props into main 2023-09-25 21:52:59 +02:00
Conversation 1 Commits 6 Files Changed 1 +2
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 497685b06d - Show all commits

2
rigify/utils/rig.py
View File

@ -437,6 +437,8 @@ def write_metarig(obj: ArmatureObject, layers=False, func_name="create",
code.append(f" soft_min={props_data['soft_min']}, ") code.append(f" soft_min={props_data['soft_min']}, ")
if 'soft_max' in props_data: if 'soft_max' in props_data:
code.append(f" soft_max={props_data['soft_max']}, ") code.append(f" soft_max={props_data['soft_max']}, ")
if 'subtype' in props_data:
code.append(f" subtype={props_data['subtype']!r}, ")
Alexander Gavrilov commented 2023-09-05 12:40:57 +02:00
Outdated
Review
Copy Link

Rather than doing '{foo}', use {repr(foo)}. Manual quoting could be barely tolerated for property names, but for the description it is simply unacceptable.

Rather than doing `'{foo}'`, use `{repr(foo)}`. Manual quoting could be barely tolerated for property names, but for the description it is simply unacceptable.
Andrej commented 2023-09-09 19:01:15 +02:00
Outdated
Review
Copy Link

that's really neat thing about repr, didn't know it can be used that way!
resolved in e2b63e1a4b

that's really neat thing about `repr`, didn't know it can be used that way! resolved in e2b63e1a4b07ffa8ca59eef5b4b2be17189f49ff
if 'description' in props_data: if 'description' in props_data:
code.append(f" description={props_data['description']!r}") code.append(f" description={props_data['description']!r}")
code.append(f" )") code.append(f" )")